Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Issue 687893002: Propagate decorators properly in telemetry_perf_unittests. (Closed)

Created:
6 years, 1 month ago by Dirk Pranke
Modified:
6 years, 1 month ago
Reviewers:
dtu, tonyg
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@switch_tel_over
Project:
chromium
Visibility:
Public.

Description

Propagate decorators properly in telemetry_perf_unittests. The load_tests() protocol we use for running the benchmark_smoke_unittests in telemetry_perf_unittests does some complicated python hacking in order to synthesize python unit test cases from the benchmark files. Prior to the fix in this patch, any decorators that were applied to the original benchmarks (in order to enable or disable tests) were being ignored. This patch makes sure the decorated enabled/disabled strings are copied over to the synthesized test method. R=tonyg@chromium.org, dtu@chromium.org BUG= Committed: https://crrev.com/50a0abfb13b02bb65ebb23ab8a208499db0c795d Cr-Commit-Position: refs/heads/master@{#301991}

Patch Set 1 #

Patch Set 2 : add a TODO to discover all tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -1 line) Patch
M tools/perf/benchmarks/benchmark_smoke_unittest.py View 1 1 chunk +15 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
Dirk Pranke
6 years, 1 month ago (2014-10-29 02:13:13 UTC) #1
tonyg
lgtm % adding a TODO about trying to find the next test in the case ...
6 years, 1 month ago (2014-10-29 19:58:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/687893002/20001
6 years, 1 month ago (2014-10-29 22:29:06 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-10-30 00:35:11 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-10-30 00:36:17 UTC) #6
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/50a0abfb13b02bb65ebb23ab8a208499db0c795d
Cr-Commit-Position: refs/heads/master@{#301991}

Powered by Google App Engine
This is Rietveld 408576698