Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Issue 687883002: Protect UpdateRTT from negative send deltas (Closed)

Created:
6 years, 1 month ago by ramant (doing other things)
Modified:
6 years, 1 month ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@Protect_against_divide_by_zero_78578198
Project:
chromium
Visibility:
Public.

Description

Protect UpdateRTT from negative send deltas Prevent negative send_deltas from being incorporated into the various RTT calculations. AFAIK, it's not happening now, but it doesn't hurt to be vigilant against future bugs. If we're getting such RTTs, it's due to some pathological error that we'd like to know about. Added a unittest for these corner cases. Low-impact. Don't use negative samples in QUIC rtt calculation. Merge internal change: 78580114 R=rch@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -3 lines) Patch
M net/quic/congestion_control/rtt_stats.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M net/quic/congestion_control/rtt_stats_test.cc View 2 chunks +38 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ramant (doing other things)
6 years, 1 month ago (2014-10-29 01:58:57 UTC) #1
ramant (doing other things)
Hi Ryan, Our version of ScopedMockLog and LOG(...) are different. Made changes to make UpdateRttWithBadSendDeltas ...
6 years, 1 month ago (2014-10-29 02:01:31 UTC) #2
Ryan Hamilton
On 2014/10/29 02:01:31, ramant wrote: > Hi Ryan, > Our version of ScopedMockLog and LOG(...) ...
6 years, 1 month ago (2014-10-29 03:00:03 UTC) #3
Ryan Hamilton
6 years, 1 month ago (2014-10-29 03:00:09 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698