cc/trees/layer_tree_host_common.cc - Issue 687873004: Introduce Property Trees

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/trees/layer_tree_host_common.cc

Issue 687873004: Introduce Property Trees (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@wip-awoloszyn2

Patch Set: . Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cc/trees/layer_tree_host_common.cc

diff --git a/cc/trees/layer_tree_host_common.cc b/cc/trees/layer_tree_host_common.cc

index 4e447b2dab9b83aaae4790ceb8368e26a92a2e28..d0ca8e2d0354be0956d7227c6ce8ae70ed6fb100 100644

--- a/cc/trees/layer_tree_host_common.cc

+++ b/cc/trees/layer_tree_host_common.cc

@@ -2418,9 +2418,11 @@ void LayerTreeHostCommon::CalculateDrawProperties(

DCHECK(inputs->root_layer->render_surface());

// Now compare with the new approach.

- OpacityTree opacity_tree;

- TransformTree transform_tree;

- ClipTree clip_tree;

+ // TODO(ajuma): Can we efficiently cache some of this rather than

+ // starting from scratch every frame?

+ OpacityTree opacity_tree(inputs->root_layer);

+ TransformTree transform_tree(inputs->root_layer);

+ ClipTree clip_tree(inputs->root_layer);

ComputeVisibleRectsUsingPropertyTrees(inputs->root_layer,

inputs->page_scale_application_layer,

inputs->page_scale_factor,