Allow the background page to get an OAuth token for apps v1.

remoting/webapp/crd/js/oauth2.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * OAuth2 class that handles retrieval/storage of an OAuth2 token.
  *
  * Uses a content script to trampoline the OAuth redirect page back into the
  * extension context.  This works around the lack of native support for
@@ skipping 219 matching lines @@
 remoting.OAuth2.prototype.onTokens_ =
     function(onOk, refreshToken, accessToken, expiresIn) {
   this.setAccessToken_(accessToken, expiresIn);
   this.setRefreshToken_(refreshToken);
   onOk();
 };
 
 /**
  * Redirect page to get a new OAuth2 Refresh Token.
  *
+ * @param {function():void} onDone Completion callback.
  * @return {void} Nothing.
  */
-remoting.OAuth2.prototype.doAuthRedirect = function() {
+remoting.OAuth2.prototype.doAuthRedirect = function(onDone) {
   /** @type {remoting.OAuth2} */
   var that = this;
-  var xsrf_token = remoting.generateXsrfToken();
+  var xsrf_token = base.generateXsrfToken();
   window.localStorage.setItem(this.KEY_XSRF_TOKEN_, xsrf_token);
   var GET_CODE_URL = this.getOAuth2AuthEndpoint_() + '?' +
     remoting.xhr.urlencodeParamHash({
           'client_id': this.getClientId_(),
           'redirect_uri': this.getRedirectUri_(),
           'scope': this.SCOPE_,
           'state': xsrf_token,
           'response_type': 'code',
           'access_type': 'offline',
           'approval_prompt': 'force'
         });
 
   /**
    * Processes the results of the oauth flow.
    *
    * @param {Object.<string, string>} message Dictionary containing the parsed
    *   OAuth redirect URL parameters.
    */
   function oauth2MessageListener(message) {
     if ('code' in message && 'state' in message) {
-      var onDone = function() {
-        window.location.reload();
-      };
       that.exchangeCodeForToken(
           message['code'], message['state'], onDone);

[kelvinp, 2014/10/29 20:28:54]

Probably need to remove onDone from line 268 as well.

[Jamie, 2014/10/30 19:38:25]

I think this is correct. We're just delegating the definition of onDone to the
caller, but since the parameter has the same name as the previous local
definition, this line doesn't change.

[kelvinp, 2014/10/30 20:48:38]

My bad.  Face palm O_O

     } else {
       if ('error' in message) {
         console.error(
             'Could not obtain authorization code: ' + message['error']);
       } else {
         // We intentionally don't log the response - since we don't understand
         // it, we can't tell if it has sensitive data.
         console.error('Invalid oauth2 response.');
       }
     }
@@ skipping 88 matching lines @@
  * @return {?string} The email address, if it has been cached by a previous call
  *     to getEmail, otherwise null.
  */
 remoting.OAuth2.prototype.getCachedEmail = function() {
   var value = window.localStorage.getItem(this.KEY_EMAIL_);
   if (typeof value == 'string') {
     return value;
   }
   return null;
 };