Allow the background page to get an OAuth token for apps v1.

Allow the background page to get an OAuth token for apps v1.

BUG=

Committed: https://crrev.com/6d20d9e00d4ad328e59f04fb2dfba6cec65bf40c
Cr-Commit-Position: refs/heads/master@{#302172}

[Jamie, 2014-10-29 01:35:59]

jamiewalch@chromium.org changed reviewers:
+ kelvinp@chromium.org

[Jamie, 2014-10-29 01:35:59]

ptal

https://codereview.chromium.org/687873003/diff/1/remoting/webapp/base/js/base.js
File remoting/webapp/base/js/base.js (right):

https://codereview.chromium.org/687873003/diff/1/remoting/webapp/base/js/base...
remoting/webapp/base/js/base.js:441: function jsonParseSafe(jsonString) {
This should be moved into the base namespace, but I wanted to avoid too much
churn in this CL (I would have taken the same approach for generateXsrfToken,
but it was previously declared in a namespace that doesn't exist in this file).
LMK if you'd like it fixed up as part of this CL as opposed to a follow-up.

[kelvinp, 2014-10-29 20:28:54]

https://codereview.chromium.org/687873003/diff/1/remoting/webapp/base/js/base.js
File remoting/webapp/base/js/base.js (right):

https://codereview.chromium.org/687873003/diff/1/remoting/webapp/base/js/base...
remoting/webapp/base/js/base.js:441: function jsonParseSafe(jsonString) {
On 2014/10/29 01:35:59, Jamie wrote:
> This should be moved into the base namespace, but I wanted to avoid too much
> churn in this CL (I would have taken the same approach for generateXsrfToken,
> but it was previously declared in a namespace that doesn't exist in this
file).
> LMK if you'd like it fixed up as part of this CL as opposed to a follow-up.

I think it may be easier to fix it up as part of this CL.  I would rather make
this CL a little bigger (fixes the 8 call sites of json parse safe) than to
leave code in base.js in the global namespace.

https://codereview.chromium.org/687873003/diff/1/remoting/webapp/crd/js/oauth...
File remoting/webapp/crd/js/oauth2.js (right):

https://codereview.chromium.org/687873003/diff/1/remoting/webapp/crd/js/oauth...
remoting/webapp/crd/js/oauth2.js:268: message['code'], message['state'],
onDone);
Probably need to remove onDone from line 268 as well.

[Jamie, 2014-10-30 19:38:25]

ptal

https://codereview.chromium.org/687873003/diff/1/remoting/webapp/base/js/base.js
File remoting/webapp/base/js/base.js (right):

https://codereview.chromium.org/687873003/diff/1/remoting/webapp/base/js/base...
remoting/webapp/base/js/base.js:441: function jsonParseSafe(jsonString) {
On 2014/10/29 20:28:54, kelvinp wrote:
> On 2014/10/29 01:35:59, Jamie wrote:
> > This should be moved into the base namespace, but I wanted to avoid too much
> > churn in this CL (I would have taken the same approach for
generateXsrfToken,
> > but it was previously declared in a namespace that doesn't exist in this
> file).
> > LMK if you'd like it fixed up as part of this CL as opposed to a follow-up.
> 
> I think it may be easier to fix it up as part of this CL.  I would rather make
> this CL a little bigger (fixes the 8 call sites of json parse safe) than to
> leave code in base.js in the global namespace.

In retrospect, I agree. Done.

https://codereview.chromium.org/687873003/diff/1/remoting/webapp/crd/js/oauth...
File remoting/webapp/crd/js/oauth2.js (right):

https://codereview.chromium.org/687873003/diff/1/remoting/webapp/crd/js/oauth...
remoting/webapp/crd/js/oauth2.js:268: message['code'], message['state'],
onDone);
On 2014/10/29 20:28:54, kelvinp wrote:
> Probably need to remove onDone from line 268 as well.

I think this is correct. We're just delegating the definition of onDone to the
caller, but since the parameter has the same name as the previous local
definition, this line doesn't change.

[kelvinp, 2014-10-30 20:48:38]

lgtm

https://codereview.chromium.org/687873003/diff/1/remoting/webapp/crd/js/oauth...
File remoting/webapp/crd/js/oauth2.js (right):

https://codereview.chromium.org/687873003/diff/1/remoting/webapp/crd/js/oauth...
remoting/webapp/crd/js/oauth2.js:268: message['code'], message['state'],
onDone);
On 2014/10/30 19:38:25, Jamie wrote:
> On 2014/10/29 20:28:54, kelvinp wrote:
> > Probably need to remove onDone from line 268 as well.
> 
> I think this is correct. We're just delegating the definition of onDone to the
> caller, but since the parameter has the same name as the previous local
> definition, this line doesn't change.

My bad.  Face palm O_O

[Jamie, 2014-10-30 21:36:35]

The CQ bit was checked by jamiewalch@chromium.org

[commit-bot: I haz the power, 2014-10-30 21:38:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/687873003/20001

[commit-bot: I haz the power, 2014-10-30 22:33:24]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-10-30 22:34:06]

Patchset 2 (id:??) landed as
https://crrev.com/6d20d9e00d4ad328e59f04fb2dfba6cec65bf40c
Cr-Commit-Position: refs/heads/master@{#302172}