Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 687833002: Get net_unittests working on Windows BoringSSL port. (Closed)

Created:
6 years, 1 month ago by davidben
Modified:
6 years, 1 month ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@wincrypt
Project:
chromium
Visibility:
Public.

Description

Get net_unittests working on Windows BoringSSL port. BUG=338884 Committed: https://crrev.com/d5587416cd28f2449ec86fa2f23e0f1de04878cc Cr-Commit-Position: refs/heads/master@{#302161}

Patch Set 1 #

Total comments: 2

Patch Set 2 : sleevi comments #

Patch Set 3 : fix gn #

Unified diffs Side-by-side diffs Delta from patch set Stats (+206 lines, -200 lines) Patch
M net/BUILD.gn View 1 2 2 chunks +6 lines, -0 lines 0 comments Download
A + net/cert/sha256_legacy_support_nss_win.cc View 1 chunk +1 line, -75 lines 0 comments Download
A net/cert/sha256_legacy_support_openssl_win.cc View 1 chunk +154 lines, -0 lines 0 comments Download
M net/cert/sha256_legacy_support_win.h View 1 2 chunks +16 lines, -0 lines 0 comments Download
M net/cert/sha256_legacy_support_win.cc View 2 chunks +0 lines, -113 lines 0 comments Download
M net/cert/x509_certificate_win.cc View 1 4 chunks +19 lines, -6 lines 0 comments Download
M net/net.gyp View 2 chunks +2 lines, -0 lines 0 comments Download
M net/net.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M net/socket/ssl_session_cache_openssl.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/socket/ssl_session_cache_openssl_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/ssl/openssl_client_key_store.h View 1 chunk +2 lines, -2 lines 0 comments Download
M net/test/run_all_unittests.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
davidben
Sending this out for review now, but it depends on https://codereview.chromium.org/686883002/ and https://codereview.chromium.org/664663004/
6 years, 1 month ago (2014-10-29 16:57:17 UTC) #2
Ryan Sleevi
lgtm https://codereview.chromium.org/687833002/diff/1/net/cert/x509_certificate_win.cc File net/cert/x509_certificate_win.cc (right): https://codereview.chromium.org/687833002/diff/1/net/cert/x509_certificate_win.cc#newcode345 net/cert/x509_certificate_win.cc:345: // static Remove this comment entirely. Not gonna ...
6 years, 1 month ago (2014-10-29 20:47:59 UTC) #3
davidben
https://codereview.chromium.org/687833002/diff/1/net/cert/x509_certificate_win.cc File net/cert/x509_certificate_win.cc (right): https://codereview.chromium.org/687833002/diff/1/net/cert/x509_certificate_win.cc#newcode345 net/cert/x509_certificate_win.cc:345: // static On 2014/10/29 20:47:59, Ryan Sleevi wrote: > ...
6 years, 1 month ago (2014-10-29 23:04:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/687833002/40001
6 years, 1 month ago (2014-10-30 20:04:45 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years, 1 month ago (2014-10-30 21:44:27 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-10-30 21:45:16 UTC) #8
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/d5587416cd28f2449ec86fa2f23e0f1de04878cc
Cr-Commit-Position: refs/heads/master@{#302161}

Powered by Google App Engine
This is Rietveld 408576698