Issue 687823005: Add //examples and //services to root build target

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 687823005: Add //examples and //services to root build target (Closed)

Created:
6 years, 1 month ago by jamesr

Modified:
6 years, 1 month ago

Reviewers:
sky

CC:
mojo-reviews_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Project:
mojo

Visibility:
Public.

Add //examples and //services to root build target This makes sure they are reachable in GN even if they aren't explicitly depended on. R=sky@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/ce8c9dc932fb30dbc9fa84ee2fc09586644621a0

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	BUILD.gn	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Total messages: 4 (1 generated)

jamesr

6 years, 1 month ago (2014-11-10 19:07:12 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
ce8c9dc932fb30dbc9fa84ee2fc09586644621a0 (presubmit successful).