CodeGen: refactor unit tests using parameterized tests

sandbox/linux/seccomp-bpf/codegen_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "sandbox/linux/seccomp-bpf/codegen.h"
 
-#include <errno.h>
 #include <linux/filter.h>
 
 #include <set>
 #include <string>
 #include <vector>
 
 #include "sandbox/linux/seccomp-bpf/basicblock.h"
 #include "sandbox/linux/seccomp-bpf/errorcode.h"
 #include "sandbox/linux/seccomp-bpf/instruction.h"
-#include "sandbox/linux/seccomp-bpf/sandbox_bpf.h"
-#include "sandbox/linux/tests/unit_tests.h"
+#include "testing/gtest/include/gtest/gtest.h"
 
 namespace sandbox {
 
 // We want to access some of the private methods in the code generator. We
 // do so by defining a "friend" that makes these methods public for us.
 class CodeGenUnittestHelper : public CodeGen {
  public:
-  void FindBranchTargets(const Instruction& instructions,
-                         BranchTargets* branch_targets) {
-    CodeGen::FindBranchTargets(instructions, branch_targets);
-  }
+  using CodeGen::CutGraphIntoBasicBlocks;

[rickyz (no longer on Chrome), 2014/11/01 00:22:05]

This is way prettier, but I think using-declaration appears under the banned
C++11 features at http://chromium-cpp.appspot.com/. It looks like it's just
because of MSVS2013 support, which doesn't apply here -  - are we exempt since
this is Linux only? (I hope we are)

[mdempsky, 2014/11/01 00:59:53]

That prohibition is only against 'using' declarations that specify the base
class's constructor (which is new to C++11).  This form of 'using' declarations
(for base member functions) was already supported by C++98.

+  using CodeGen::FindBranchTargets;
+  using CodeGen::MergeTails;
+};
 
-  BasicBlock* CutGraphIntoBasicBlocks(Instruction* insns,
-                                      const BranchTargets& branch_targets,
-                                      TargetsToBlocks* blocks) {
-    return CodeGen::CutGraphIntoBasicBlocks(insns, branch_targets, blocks);
-  }
-
-  void MergeTails(TargetsToBlocks* blocks) { CodeGen::MergeTails(blocks); }
-};
+namespace {
 
 enum { NO_FLAGS = 0x0000, HAS_MERGEABLE_TAILS = 0x0001, };
 
-Instruction* SampleProgramOneInstruction(CodeGen* codegen, int* flags) {
+using ProgramTestFunc = void (*)(CodeGenUnittestHelper* gen,
+                                 Instruction* head,
+                                 int flags);
+
+class ProgramTest : public ::testing::TestWithParam<ProgramTestFunc> {
+ protected:
+  ProgramTest() : gen_(), head_(nullptr), flags_(NO_FLAGS) {}
+
+  void TearDown() override { GetParam()(&gen_, head_, flags_); }

[rickyz (no longer on Chrome), 2014/11/01 00:22:05]

It might just be me, but it's a little weird that the meat of the test happens
inside of TearDown. Instead of ending each test with head_ = ..., maybe we could
just get rid of head_ and flags_ member variables and just call
GetParam()(&gen_, head, NO_FLAGS|HAS_MERGEABLE_TAILS) at the end of each of the
tests?

[mdempsky, 2014/11/01 00:59:53]

Fair enough.  I added a RunTest() function to share the common logic, and now
call it explicitly within each test.

I also created MakeInstruction() helper functions to sanity check the
instruction fields.  (Not much of a win now, but it's going to help later when I
get rid of Instruction.)

+
+  CodeGenUnittestHelper gen_;
+  Instruction* head_;
+  int flags_;
+};
+
+TEST_P(ProgramTest, OneInstruction) {
   // Create the most basic valid BPF program:
   //    RET 0
-  *flags = NO_FLAGS;
-  return codegen->MakeInstruction(BPF_RET + BPF_K, 0);
+  flags_ = NO_FLAGS;
+  head_ = gen_.MakeInstruction(BPF_RET + BPF_K, 0);
 }
 
-Instruction* SampleProgramSimpleBranch(CodeGen* codegen, int* flags) {
+TEST_P(ProgramTest, SimpleBranch) {
   // Create a program with a single branch:
   //    JUMP if eq 42 then $0 else $1
   // 0: RET 1
   // 1: RET 0
-  *flags = NO_FLAGS;
-  return codegen->MakeInstruction(
-      BPF_JMP + BPF_JEQ + BPF_K,
-      42,
-      codegen->MakeInstruction(BPF_RET + BPF_K, 1),
-      codegen->MakeInstruction(BPF_RET + BPF_K, 0));
+  flags_ = NO_FLAGS;
+  head_ = gen_.MakeInstruction(BPF_JMP + BPF_JEQ + BPF_K,
+                               42,
+                               gen_.MakeInstruction(BPF_RET + BPF_K, 1),
+                               gen_.MakeInstruction(BPF_RET + BPF_K, 0));
 }
 
-Instruction* SampleProgramAtypicalBranch(CodeGen* codegen, int* flags) {
+TEST_P(ProgramTest, AtypicalBranch) {
   // Create a program with a single branch:
   //    JUMP if eq 42 then $0 else $0
   // 0: RET 0
 
   // N.B.: As the instructions in both sides of the branch are already
   //       the same object, we do not actually have any "mergeable" branches.
   //       This needs to be reflected in our choice of "flags".
-  *flags = NO_FLAGS;
+  flags_ = NO_FLAGS;
 
-  Instruction* ret = codegen->MakeInstruction(
-      BPF_RET + BPF_K, 0);
-  return codegen->MakeInstruction(BPF_JMP + BPF_JEQ + BPF_K, 42, ret, ret);
+  Instruction* ret = gen_.MakeInstruction(BPF_RET + BPF_K, 0);
+  head_ = gen_.MakeInstruction(BPF_JMP + BPF_JEQ + BPF_K, 42, ret, ret);
 }
 
-Instruction* SampleProgramComplex(CodeGen* codegen, int* flags) {
+TEST_P(ProgramTest, Complex) {
   // Creates a basic BPF program that we'll use to test some of the code:
   //    JUMP if eq 42 the $0 else $1     (insn6)
   // 0: LD 23                            (insn5)
   // 1: JUMP if eq 42 then $2 else $4    (insn4)
   // 2: JUMP to $3                       (insn2)
   // 3: LD 42                            (insn1)
   //    RET 42                           (insn0)
   // 4: LD 42                            (insn3)
   //    RET 42                           (insn3+)
-  *flags = HAS_MERGEABLE_TAILS;
+  flags_ = HAS_MERGEABLE_TAILS;
 
-  Instruction* insn0 = codegen->MakeInstruction(BPF_RET + BPF_K, 42);
-  SANDBOX_ASSERT(insn0);
-  SANDBOX_ASSERT(insn0->code == BPF_RET + BPF_K);
-  SANDBOX_ASSERT(insn0->next == NULL);
+  Instruction* insn0 = gen_.MakeInstruction(BPF_RET + BPF_K, 42);
+  ASSERT_TRUE(insn0);
+  ASSERT_TRUE(insn0->code == BPF_RET + BPF_K);
+  ASSERT_TRUE(insn0->next == NULL);
 
   Instruction* insn1 =
-      codegen->MakeInstruction(BPF_LD + BPF_W + BPF_ABS, 42, insn0);
-  SANDBOX_ASSERT(insn1);
-  SANDBOX_ASSERT(insn1->code == BPF_LD + BPF_W + BPF_ABS);
-  SANDBOX_ASSERT(insn1->k == 42);
-  SANDBOX_ASSERT(insn1->next == insn0);
+      gen_.MakeInstruction(BPF_LD + BPF_W + BPF_ABS, 42, insn0);
+  ASSERT_TRUE(insn1);
+  ASSERT_TRUE(insn1->code == BPF_LD + BPF_W + BPF_ABS);
+  ASSERT_TRUE(insn1->k == 42);
+  ASSERT_TRUE(insn1->next == insn0);
 
-  Instruction* insn2 = codegen->MakeInstruction(BPF_JMP + BPF_JA, 0, insn1);
-  SANDBOX_ASSERT(insn2);
-  SANDBOX_ASSERT(insn2->code == BPF_JMP + BPF_JA);
-  SANDBOX_ASSERT(insn2->jt_ptr == insn1);
+  Instruction* insn2 = gen_.MakeInstruction(BPF_JMP + BPF_JA, 0, insn1);
+  ASSERT_TRUE(insn2);
+  ASSERT_TRUE(insn2->code == BPF_JMP + BPF_JA);
+  ASSERT_TRUE(insn2->jt_ptr == insn1);
 
   // We explicitly duplicate instructions so that MergeTails() can coalesce
   // them later.
-  Instruction* insn3 = codegen->MakeInstruction(
-      BPF_LD + BPF_W + BPF_ABS,
-      42,
-      codegen->MakeInstruction(BPF_RET + BPF_K, 42));
+  Instruction* insn3 = gen_.MakeInstruction(
+      BPF_LD + BPF_W + BPF_ABS, 42, gen_.MakeInstruction(BPF_RET + BPF_K, 42));
 
   Instruction* insn4 =
-      codegen->MakeInstruction(BPF_JMP + BPF_JEQ + BPF_K, 42, insn2, insn3);
-  SANDBOX_ASSERT(insn4);
-  SANDBOX_ASSERT(insn4->code == BPF_JMP + BPF_JEQ + BPF_K);
-  SANDBOX_ASSERT(insn4->k == 42);
-  SANDBOX_ASSERT(insn4->jt_ptr == insn2);
-  SANDBOX_ASSERT(insn4->jf_ptr == insn3);
+      gen_.MakeInstruction(BPF_JMP + BPF_JEQ + BPF_K, 42, insn2, insn3);
+  ASSERT_TRUE(insn4);
+  ASSERT_TRUE(insn4->code == BPF_JMP + BPF_JEQ + BPF_K);
+  ASSERT_TRUE(insn4->k == 42);
+  ASSERT_TRUE(insn4->jt_ptr == insn2);
+  ASSERT_TRUE(insn4->jf_ptr == insn3);
 
   Instruction* insn5 =
-      codegen->MakeInstruction(BPF_LD + BPF_W + BPF_ABS, 23, insn4);
-  SANDBOX_ASSERT(insn5);
-  SANDBOX_ASSERT(insn5->code == BPF_LD + BPF_W + BPF_ABS);
-  SANDBOX_ASSERT(insn5->k == 23);
-  SANDBOX_ASSERT(insn5->next == insn4);
+      gen_.MakeInstruction(BPF_LD + BPF_W + BPF_ABS, 23, insn4);
+  ASSERT_TRUE(insn5);
+  ASSERT_TRUE(insn5->code == BPF_LD + BPF_W + BPF_ABS);
+  ASSERT_TRUE(insn5->k == 23);
+  ASSERT_TRUE(insn5->next == insn4);
 
   // Force a basic block that ends in neither a jump instruction nor a return
   // instruction. It only contains "insn5". This exercises one of the less
   // common code paths in the topo-sort algorithm.
   // This also gives us a diamond-shaped pattern in our graph, which stresses
   // another aspect of the topo-sort algorithm (namely, the ability to
   // correctly count the incoming branches for subtrees that are not disjunct).
   Instruction* insn6 =
-      codegen->MakeInstruction(BPF_JMP + BPF_JEQ + BPF_K, 42, insn5, insn4);
+      gen_.MakeInstruction(BPF_JMP + BPF_JEQ + BPF_K, 42, insn5, insn4);
 
-  return insn6;
+  head_ = insn6;
 }
 
-Instruction* SampleProgramConfusingTails(CodeGen* codegen, int* flags) {
+TEST_P(ProgramTest, ConfusingTails) {
   // This simple program demonstrates https://crbug.com/351103/
   // The two "LOAD 0" instructions are blocks of their own. MergeTails() could
   // be tempted to merge them since they are the same. However, they are
   // not mergeable because they fall-through to non semantically equivalent
   // blocks.
   // Without the fix for this bug, this program should trigger the check in
   // CompileAndCompare: the serialized graphs from the program and its compiled
   // version will differ.
   //
   //  0) LOAD 1  // ???
   //  1) if A == 0x1; then JMP 2 else JMP 3
   //  2) LOAD 0  // System call number
   //  3) if A == 0x2; then JMP 4 else JMP 5
   //  4) LOAD 0  // System call number
   //  5) if A == 0x1; then JMP 6 else JMP 7
   //  6) RET 0
   //  7) RET 1
-  *flags = NO_FLAGS;
+  flags_ = NO_FLAGS;
 
-  Instruction* i7 = codegen->MakeInstruction(BPF_RET + BPF_K, 1);
-  Instruction* i6 = codegen->MakeInstruction(BPF_RET + BPF_K, 0);
-  Instruction* i5 =
-      codegen->MakeInstruction(BPF_JMP + BPF_JEQ + BPF_K, 1, i6, i7);
-  Instruction* i4 = codegen->MakeInstruction(BPF_LD + BPF_W + BPF_ABS, 0, i5);
-  Instruction* i3 =
-      codegen->MakeInstruction(BPF_JMP + BPF_JEQ + BPF_K, 2, i4, i5);
-  Instruction* i2 = codegen->MakeInstruction(BPF_LD + BPF_W + BPF_ABS, 0, i3);
-  Instruction* i1 =
-      codegen->MakeInstruction(BPF_JMP + BPF_JEQ + BPF_K, 1, i2, i3);
-  Instruction* i0 = codegen->MakeInstruction(BPF_LD + BPF_W + BPF_ABS, 1, i1);
+  Instruction* i7 = gen_.MakeInstruction(BPF_RET + BPF_K, 1);
+  Instruction* i6 = gen_.MakeInstruction(BPF_RET + BPF_K, 0);
+  Instruction* i5 = gen_.MakeInstruction(BPF_JMP + BPF_JEQ + BPF_K, 1, i6, i7);
+  Instruction* i4 = gen_.MakeInstruction(BPF_LD + BPF_W + BPF_ABS, 0, i5);
+  Instruction* i3 = gen_.MakeInstruction(BPF_JMP + BPF_JEQ + BPF_K, 2, i4, i5);
+  Instruction* i2 = gen_.MakeInstruction(BPF_LD + BPF_W + BPF_ABS, 0, i3);
+  Instruction* i1 = gen_.MakeInstruction(BPF_JMP + BPF_JEQ + BPF_K, 1, i2, i3);
+  Instruction* i0 = gen_.MakeInstruction(BPF_LD + BPF_W + BPF_ABS, 1, i1);
 
-  return i0;
+  head_ = i0;
 }
 
-Instruction* SampleProgramConfusingTailsBasic(CodeGen* codegen, int* flags) {
+TEST_P(ProgramTest, ConfusingTailsBasic) {
   // Without the fix for https://crbug.com/351103/, (see
   // SampleProgramConfusingTails()), this would generate a cyclic graph and
   // crash as the two "LOAD 0" instructions would get merged.
   //
   // 0) LOAD 1  // ???
   // 1) if A == 0x1; then JMP 2 else JMP 3
   // 2) LOAD 0  // System call number
   // 3) if A == 0x2; then JMP 4 else JMP 5
   // 4) LOAD 0  // System call number
   // 5) RET 1
-  *flags = NO_FLAGS;
+  flags_ = NO_FLAGS;
 
-  Instruction* i5 = codegen->MakeInstruction(BPF_RET + BPF_K, 1);
-  Instruction* i4 = codegen->MakeInstruction(BPF_LD + BPF_W + BPF_ABS, 0, i5);
-  Instruction* i3 =
-      codegen->MakeInstruction(BPF_JMP + BPF_JEQ + BPF_K, 2, i4, i5);
-  Instruction* i2 = codegen->MakeInstruction(BPF_LD + BPF_W + BPF_ABS, 0, i3);
-  Instruction* i1 =
-      codegen->MakeInstruction(BPF_JMP + BPF_JEQ + BPF_K, 1, i2, i3);
-  Instruction* i0 = codegen->MakeInstruction(BPF_LD + BPF_W + BPF_ABS, 1, i1);
+  Instruction* i5 = gen_.MakeInstruction(BPF_RET + BPF_K, 1);
+  Instruction* i4 = gen_.MakeInstruction(BPF_LD + BPF_W + BPF_ABS, 0, i5);
+  Instruction* i3 = gen_.MakeInstruction(BPF_JMP + BPF_JEQ + BPF_K, 2, i4, i5);
+  Instruction* i2 = gen_.MakeInstruction(BPF_LD + BPF_W + BPF_ABS, 0, i3);
+  Instruction* i1 = gen_.MakeInstruction(BPF_JMP + BPF_JEQ + BPF_K, 1, i2, i3);
+  Instruction* i0 = gen_.MakeInstruction(BPF_LD + BPF_W + BPF_ABS, 1, i1);
 
-  return i0;
+  head_ = i0;
 }
 
-Instruction* SampleProgramConfusingTailsMergeable(CodeGen* codegen,
-                                                  int* flags) {
+TEST_P(ProgramTest, ConfusingTailsMergeable) {
   // This is similar to SampleProgramConfusingTails(), except that
   // instructions 2 and 4 are now RET instructions.
   // In PointerCompare(), this exercises the path where two blocks are of the
   // same length and identical and the last instruction is a JMP or RET, so the
   // following blocks don't need to be looked at and the blocks are mergeable.
   //
   // 0) LOAD 1  // ???
   // 1) if A == 0x1; then JMP 2 else JMP 3
   // 2) RET 42
   // 3) if A == 0x2; then JMP 4 else JMP 5
   // 4) RET 42
   // 5) if A == 0x1; then JMP 6 else JMP 7
   // 6) RET 0
   // 7) RET 1
-  *flags = HAS_MERGEABLE_TAILS;
+  flags_ = HAS_MERGEABLE_TAILS;
 
-  Instruction* i7 = codegen->MakeInstruction(BPF_RET + BPF_K, 1);
-  Instruction* i6 = codegen->MakeInstruction(BPF_RET + BPF_K, 0);
-  Instruction* i5 =
-      codegen->MakeInstruction(BPF_JMP + BPF_JEQ + BPF_K, 1, i6, i7);
-  Instruction* i4 = codegen->MakeInstruction(BPF_RET + BPF_K, 42);
-  Instruction* i3 =
-      codegen->MakeInstruction(BPF_JMP + BPF_JEQ + BPF_K, 2, i4, i5);
-  Instruction* i2 = codegen->MakeInstruction(BPF_RET + BPF_K, 42);
-  Instruction* i1 =
-      codegen->MakeInstruction(BPF_JMP + BPF_JEQ + BPF_K, 1, i2, i3);
-  Instruction* i0 = codegen->MakeInstruction(BPF_LD + BPF_W + BPF_ABS, 1, i1);
+  Instruction* i7 = gen_.MakeInstruction(BPF_RET + BPF_K, 1);
+  Instruction* i6 = gen_.MakeInstruction(BPF_RET + BPF_K, 0);
+  Instruction* i5 = gen_.MakeInstruction(BPF_JMP + BPF_JEQ + BPF_K, 1, i6, i7);
+  Instruction* i4 = gen_.MakeInstruction(BPF_RET + BPF_K, 42);
+  Instruction* i3 = gen_.MakeInstruction(BPF_JMP + BPF_JEQ + BPF_K, 2, i4, i5);
+  Instruction* i2 = gen_.MakeInstruction(BPF_RET + BPF_K, 42);
+  Instruction* i1 = gen_.MakeInstruction(BPF_JMP + BPF_JEQ + BPF_K, 1, i2, i3);
+  Instruction* i0 = gen_.MakeInstruction(BPF_LD + BPF_W + BPF_ABS, 1, i1);
 
-  return i0;
-}
-void ForAllPrograms(void (*test)(CodeGenUnittestHelper*, Instruction*, int)) {
-  Instruction* (*function_table[])(CodeGen* codegen, int* flags) = {
-    SampleProgramOneInstruction,
-    SampleProgramSimpleBranch,
-    SampleProgramAtypicalBranch,
-    SampleProgramComplex,
-    SampleProgramConfusingTails,
-    SampleProgramConfusingTailsBasic,
-    SampleProgramConfusingTailsMergeable,
-  };
-
-  for (size_t i = 0; i < arraysize(function_table); ++i) {
-    CodeGenUnittestHelper codegen;
-    int flags = NO_FLAGS;
-    Instruction *prg = function_table[i](&codegen, &flags);
-    test(&codegen, prg, flags);
-  }
+  head_ = i0;
 }
 
 void MakeInstruction(CodeGenUnittestHelper* codegen,
                      Instruction* program, int) {
   // Nothing to do here
 }
 
-SANDBOX_TEST(CodeGen, MakeInstruction) {
-  ForAllPrograms(MakeInstruction);
-}
-
 void FindBranchTargets(CodeGenUnittestHelper* codegen, Instruction* prg, int) {
   BranchTargets branch_targets;
   codegen->FindBranchTargets(*prg, &branch_targets);
 
   // Verifying the general properties that should be true for every
   // well-formed BPF program.
   // Perform a depth-first traversal of the BPF program an verify that all
   // targets of BPF_JMP instructions are represented in the "branch_targets".
   // At the same time, compute a set of both the branch targets and all the
   // instructions in the program.
   std::vector<Instruction*> stack;
   std::set<Instruction*> all_instructions;
   std::set<Instruction*> target_instructions;
   BranchTargets::const_iterator end = branch_targets.end();
   for (Instruction* insn = prg;;) {
     all_instructions.insert(insn);
     if (BPF_CLASS(insn->code) == BPF_JMP) {
       target_instructions.insert(insn->jt_ptr);
-      SANDBOX_ASSERT(insn->jt_ptr != NULL);
-      SANDBOX_ASSERT(branch_targets.find(insn->jt_ptr) != end);
+      ASSERT_TRUE(insn->jt_ptr != NULL);
+      ASSERT_TRUE(branch_targets.find(insn->jt_ptr) != end);
       if (BPF_OP(insn->code) != BPF_JA) {
         target_instructions.insert(insn->jf_ptr);
-        SANDBOX_ASSERT(insn->jf_ptr != NULL);
-        SANDBOX_ASSERT(branch_targets.find(insn->jf_ptr) != end);
+        ASSERT_TRUE(insn->jf_ptr != NULL);
+        ASSERT_TRUE(branch_targets.find(insn->jf_ptr) != end);
         stack.push_back(insn->jf_ptr);
       }
       insn = insn->jt_ptr;
     } else if (BPF_CLASS(insn->code) == BPF_RET) {
-      SANDBOX_ASSERT(insn->next == NULL);
+      ASSERT_TRUE(insn->next == NULL);
       if (stack.empty()) {
         break;
       }
       insn = stack.back();
       stack.pop_back();
     } else {
-      SANDBOX_ASSERT(insn->next != NULL);
+      ASSERT_TRUE(insn->next != NULL);
       insn = insn->next;
     }
   }
-  SANDBOX_ASSERT(target_instructions.size() == branch_targets.size());
+  ASSERT_TRUE(target_instructions.size() == branch_targets.size());
 
   // We can now subtract the set of the branch targets from the set of all
   // instructions. This gives us a set with the instructions that nobody
   // ever jumps to. Verify that they are no included in the
   // "branch_targets" that FindBranchTargets() computed for us.
   Instructions non_target_instructions(all_instructions.size() -
                                        target_instructions.size());
   set_difference(all_instructions.begin(),
                  all_instructions.end(),
                  target_instructions.begin(),
                  target_instructions.end(),
                  non_target_instructions.begin());
   for (Instructions::const_iterator iter = non_target_instructions.begin();
        iter != non_target_instructions.end();
        ++iter) {
-    SANDBOX_ASSERT(branch_targets.find(*iter) == end);
+    ASSERT_TRUE(branch_targets.find(*iter) == end);
   }
 }
 
-SANDBOX_TEST(CodeGen, FindBranchTargets) { ForAllPrograms(FindBranchTargets); }
-
 void CutGraphIntoBasicBlocks(CodeGenUnittestHelper* codegen,
                              Instruction* prg,
                              int) {
   BranchTargets branch_targets;
   codegen->FindBranchTargets(*prg, &branch_targets);
   TargetsToBlocks all_blocks;
   BasicBlock* first_block =
       codegen->CutGraphIntoBasicBlocks(prg, branch_targets, &all_blocks);
-  SANDBOX_ASSERT(first_block != NULL);
-  SANDBOX_ASSERT(first_block->instructions.size() > 0);
+  ASSERT_TRUE(first_block != NULL);
+  ASSERT_TRUE(first_block->instructions.size() > 0);
   Instruction* first_insn = first_block->instructions[0];
 
   // Basic blocks are supposed to start with a branch target and end with
   // either a jump or a return instruction. It can also end, if the next
   // instruction forms the beginning of a new basic block. There should be
   // no other jumps or return instructions in the middle of a basic block.
   for (TargetsToBlocks::const_iterator bb_iter = all_blocks.begin();
        bb_iter != all_blocks.end();
        ++bb_iter) {
     BasicBlock* bb = bb_iter->second;
-    SANDBOX_ASSERT(bb != NULL);
-    SANDBOX_ASSERT(bb->instructions.size() > 0);
+    ASSERT_TRUE(bb != NULL);
+    ASSERT_TRUE(bb->instructions.size() > 0);
     Instruction* insn = bb->instructions[0];
-    SANDBOX_ASSERT(insn == first_insn ||
-                   branch_targets.find(insn) != branch_targets.end());
+    ASSERT_TRUE(insn == first_insn ||
+                branch_targets.find(insn) != branch_targets.end());
     for (Instructions::const_iterator insn_iter = bb->instructions.begin();;) {
       insn = *insn_iter;
       if (++insn_iter != bb->instructions.end()) {
-        SANDBOX_ASSERT(BPF_CLASS(insn->code) != BPF_JMP);
-        SANDBOX_ASSERT(BPF_CLASS(insn->code) != BPF_RET);
+        ASSERT_TRUE(BPF_CLASS(insn->code) != BPF_JMP);
+        ASSERT_TRUE(BPF_CLASS(insn->code) != BPF_RET);
       } else {
-        SANDBOX_ASSERT(BPF_CLASS(insn->code) == BPF_JMP ||
-                       BPF_CLASS(insn->code) == BPF_RET ||
-                       branch_targets.find(insn->next) != branch_targets.end());
+        ASSERT_TRUE(BPF_CLASS(insn->code) == BPF_JMP ||
+                    BPF_CLASS(insn->code) == BPF_RET ||
+                    branch_targets.find(insn->next) != branch_targets.end());
         break;
       }
-      SANDBOX_ASSERT(branch_targets.find(*insn_iter) == branch_targets.end());
+      ASSERT_TRUE(branch_targets.find(*insn_iter) == branch_targets.end());
     }
   }
 }
 
-SANDBOX_TEST(CodeGen, CutGraphIntoBasicBlocks) {
-  ForAllPrograms(CutGraphIntoBasicBlocks);
-}
-
 void MergeTails(CodeGenUnittestHelper* codegen, Instruction* prg, int flags) {
   BranchTargets branch_targets;
   codegen->FindBranchTargets(*prg, &branch_targets);
   TargetsToBlocks all_blocks;
   BasicBlock* first_block =
       codegen->CutGraphIntoBasicBlocks(prg, branch_targets, &all_blocks);
 
   // The shape of our graph and thus the function of our program should
   // still be unchanged after we run MergeTails(). We verify this by
   // serializing the graph and verifying that it is still the same.
@@ skipping 52 matching lines @@
         bb = all_blocks[insn->next];
       }
     }
 
     // Our loop runs exactly two times.
     if (++i > 1) {
       break;
     }
     codegen->MergeTails(&all_blocks);
   }
-  SANDBOX_ASSERT(graph[0] == graph[1]);
+  ASSERT_TRUE(graph[0] == graph[1]);
   if (flags & HAS_MERGEABLE_TAILS) {
-    SANDBOX_ASSERT(edges[0] != edges[1]);
+    ASSERT_TRUE(edges[0] != edges[1]);
   } else {
-    SANDBOX_ASSERT(edges[0] == edges[1]);
+    ASSERT_TRUE(edges[0] == edges[1]);
   }
 }
 
-SANDBOX_TEST(CodeGen, MergeTails) {
-  ForAllPrograms(MergeTails);
-}
-
 void CompileAndCompare(CodeGenUnittestHelper* codegen, Instruction* prg, int) {
   // TopoSortBasicBlocks() has internal checks that cause it to fail, if it
   // detects a problem. Typically, if anything goes wrong, this looks to the
   // TopoSort algorithm as if there had been cycles in the input data.
   // This provides a pretty good unittest.
   // We hand-crafted the program returned by SampleProgram() to exercise
   // several of the more interesting code-paths. See comments in
   // SampleProgram() for details.
   // In addition to relying on the internal consistency checks in the compiler,
   // we also serialize the graph and the resulting BPF program and compare
@@ skipping 32 matching lines @@
   }
 
   // Compile the program
   CodeGen::Program bpf;
   codegen->Compile(prg, &bpf);
 
   // Serialize the resulting BPF instructions.
   std::string assembly;
   std::vector<int> assembly_stack;
   for (int idx = 0; idx >= 0;) {
-    SANDBOX_ASSERT(idx < (int)bpf.size());
+    ASSERT_TRUE(idx < (int)bpf.size());
     struct sock_filter& insn = bpf[idx];
     if (BPF_CLASS(insn.code) == BPF_JMP) {
       if (BPF_OP(insn.code) == BPF_JA) {
         // Do not serialize BPF_JA instructions (see above).
         idx += insn.k + 1;
         continue;
       } else {
         assembly_stack.push_back(idx + insn.jf + 1);
         idx += insn.jt + 1;
       }
     } else if (BPF_CLASS(insn.code) == BPF_RET) {
       if (assembly_stack.empty()) {
         idx = -1;
       } else {
         idx = assembly_stack.back();
         assembly_stack.pop_back();
       }
     } else {
       ++idx;
     }
     // Serialize the same information that we serialized before compilation.
     assembly.append(reinterpret_cast<char*>(&insn.code), sizeof(insn.code));
     assembly.append(reinterpret_cast<char*>(&insn.k), sizeof(insn.k));
   }
-  SANDBOX_ASSERT(source == assembly);
+  ASSERT_TRUE(source == assembly);
 }
 
-SANDBOX_TEST(CodeGen, All) {
-  ForAllPrograms(CompileAndCompare);
-}
+const ProgramTestFunc kProgramTestFuncs[] = {
+    MakeInstruction,
+    FindBranchTargets,
+    CutGraphIntoBasicBlocks,
+    MergeTails,
+    CompileAndCompare,
+};
+
+INSTANTIATE_TEST_CASE_P(CodeGen,
+                        ProgramTest,
+                        ::testing::ValuesIn(kProgramTestFuncs));
+
+}  // namespace
 
 }  // namespace sandbox