Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(155)

Issue 6878068: Fix cryptohome unittest compile (Closed)

Created:
9 years, 9 months ago by gauravsh
Modified:
9 years, 7 months ago
Reviewers:
Chris Masone, kmixter1
CC:
chromium-os-reviews_chromium.org, Chris Masone, gauravsh, Will Drewry
Visibility:
Public.

Description

Fix cryptohome unittest compile Change-Id: I9343dec603936cc3bcea0284e3c277446c68da5e BUG=none TEST=Build with FEATURES=test emerge-x86-generic chromeos-base/chromeos-cryptohome (tests build and pass now) Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=c69f3f8

Patch Set 1 #

Patch Set 2 : one more #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M service_unittest.cc View 1 3 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
gauravsh
9 years, 9 months ago (2011-04-20 03:52:53 UTC) #1
Chris Masone
LGTM
9 years, 9 months ago (2011-04-20 03:54:07 UTC) #2
kmixter1
Heh - I was just looking into that... LGTM On Tue, Apr 19, 2011 at ...
9 years, 9 months ago (2011-04-20 04:01:07 UTC) #3
gauravsh
9 years, 9 months ago (2011-04-20 04:04:07 UTC) #4
Yeah, out of 10 things I need to run to make sure my change doesn't break
things, I always forget one. Sorry about that.
On Apr 19, 2011 9:01 PM, "Ken Mixter" <kmixter@chromium.org> wrote:
> Heh - I was just looking into that... LGTM
>
> On Tue, Apr 19, 2011 at 8:54 PM, <cmasone@chromium.org> wrote:
>> LGTM
>>
>> http://codereview.chromium.org/6878068/
>>

Powered by Google App Engine
This is Rietveld 408576698