Chromium Code Reviews (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

Issue 6878043: Get rid of prefixes in General Dynamic TLS code for x86_64-nacl (Closed)

9 years, 8 months ago by eaeltsin
9 years, 7 months ago
Base URL:


Get rid of prefixes in GD TLS for x86_64-nacl Standard GD TLS sequence contains commands prefixed with 0x6666, inserted by compiler with .byte directive. Our asm does not know how to move it around, and thus 0x6666 may cross bundle boundary and confuse the validator. As we do not rewrite GD TLS access pattern at the moment, we can afford changing the standard sequence. Simply removing prefixes make still working code that does not suffer from the issues described above. BUG= TEST=disassemble object file from any source accessing __thread variable - it should not have 0x6666 any more Committed:;a=commit;h=df9e2bf

Patch Set 1 #

Patch Set 2 : ready for code review #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M gcc/config/i386/ View 1 chunk +5 lines, -1 line 1 comment Download


Total messages: 7 (0 generated)
9 years, 8 months ago (2011-04-19 14:53:37 UTC) #1
Brad Chen
What is GD? Brad On Tue, Apr 19, 2011 at 7:53 AM, <> wrote: > ...
9 years, 8 months ago (2011-04-19 15:21:46 UTC) #2
One nit, o/w LGTM File gcc/config/i386/ (right): gcc/config/i386/ return ".byte\t0x66\n\tlea{q}\t{%a1@TLSGD(%%rip), %%rdi|rdi, %a1@TLSGD[rip]}\n" ASM_SHORT ...
9 years, 8 months ago (2011-04-19 15:26:23 UTC) #3
Sorry for using ambiguous acronym. Here GD stands for General Dynamic TLS model. Renamed the ...
9 years, 8 months ago (2011-04-19 15:27:39 UTC) #4
Roland McGrath
I do have reservations about too many tweaks to the code generation, especially when they ...
9 years, 8 months ago (2011-04-19 16:27:21 UTC) #5
I think I'll rollback this as soon as we fix the assembler so it does ...
9 years, 8 months ago (2011-04-19 17:37:22 UTC) #6
Use instead
9 years, 8 months ago (2011-04-19 18:47:36 UTC) #7
Agreed.  I have thoughts about cleaning up the assembler picture, but I
don't think it is something to get into very soon.

You received this message because you are subscribed to the Google Groups
"Native-Client-Reviews" group.
To post to this group, send email to
To unsubscribe from this group, send email to
For more options, visit this group at

Powered by Google App Engine
This is Rietveld 408576698