Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Issue 687803009: aw: Add test to ensure hardware mode works (Closed)

Created:
6 years, 1 month ago by boliu
Modified:
6 years, 1 month ago
Reviewers:
no sievers
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

aw: Add test to ensure hardware mode works We might accidentally turn off hardware acceleration in instrumentation tests without knowing since tests are supposed to work in software mode as well. So add a meta test to check this. BUG= Committed: https://crrev.com/8aa9b775556f58cfddb77dcafc28e28e22de6732 Cr-Commit-Position: refs/heads/master@{#302690}

Patch Set 1 #

Patch Set 2 : blank line #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -7 lines) Patch
M android_webview/javatests/src/org/chromium/android_webview/test/AwContentsTest.java View 1 1 chunk +11 lines, -0 lines 0 comments Download
M android_webview/test/shell/src/org/chromium/android_webview/test/AwTestContainerView.java View 6 chunks +11 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
boliu
ptal
6 years, 1 month ago (2014-11-04 21:46:41 UTC) #2
no sievers
lgtm
6 years, 1 month ago (2014-11-04 21:50:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/687803009/20001
6 years, 1 month ago (2014-11-04 21:52:36 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-11-04 22:38:43 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-04 22:40:00 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8aa9b775556f58cfddb77dcafc28e28e22de6732
Cr-Commit-Position: refs/heads/master@{#302690}

Powered by Google App Engine
This is Rietveld 408576698