Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 687803005: [content/browser/media] Convert VLOGs to DVLOGs (Closed)

Created:
6 years, 1 month ago by anujsharma
Modified:
6 years, 1 month ago
CC:
chromium-reviews, DaleCurtis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[content/browser/media] Convert VLOGs to DVLOGs BUG=101424 TBR=vrk@chromium.org Committed: https://crrev.com/9da298e189db8751ca75039d4db49e9d5dab7247 Cr-Commit-Position: refs/heads/master@{#303188}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -34 lines) Patch
M chrome/browser/media/chrome_webrtc_apprtc_browsertest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/media/chrome_webrtc_audio_quality_browsertest.cc View 6 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/media/chrome_webrtc_video_quality_browsertest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/media/encrypted_media_browsertest.cc View 6 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/media/media_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media/test_license_server.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/media/wv_test_license_server_config.cc View 4 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 20 (7 generated)
anujsharma
PTAL
6 years, 1 month ago (2014-11-03 12:53:45 UTC) #2
sky
Same comment as last one.
6 years, 1 month ago (2014-11-03 16:31:40 UTC) #4
anujsharma
On 2014/11/03 16:31:40, sky wrote: > Same comment as last one. @DaleCurtis - PTAL
6 years, 1 month ago (2014-11-04 04:00:23 UTC) #6
DaleCurtis
-> xhwang since it changes mostly EME stuff.
6 years, 1 month ago (2014-11-04 18:38:02 UTC) #8
xhwang
+glaznev for WebRTC changes. otherwise, LGTM
6 years, 1 month ago (2014-11-04 18:45:59 UTC) #10
AlexGlaznev
On 2014/11/04 18:45:59, xhwang wrote: > +glaznev for WebRTC changes. > > otherwise, LGTM Not ...
6 years, 1 month ago (2014-11-04 19:01:50 UTC) #12
anujsharma
On 2014/11/04 18:45:59, xhwang wrote: > +glaznev for WebRTC changes. > > otherwise, LGTM Thanks ...
6 years, 1 month ago (2014-11-05 12:49:19 UTC) #13
anujsharma
@xhwang, Should I wait on vrk or is it alright to commit?
6 years, 1 month ago (2014-11-06 13:44:55 UTC) #14
xhwang
This only affects logs, I *think* it's okay to commit. You can add vrk as ...
6 years, 1 month ago (2014-11-06 16:58:59 UTC) #15
anujsharma
On 2014/11/06 16:58:59, xhwang wrote: > This only affects logs, I *think* it's okay to ...
6 years, 1 month ago (2014-11-07 04:02:00 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/687803005/1
6 years, 1 month ago (2014-11-07 04:03:07 UTC) #18
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-07 04:48:57 UTC) #19
commit-bot: I haz the power
6 years, 1 month ago (2014-11-07 04:49:50 UTC) #20
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9da298e189db8751ca75039d4db49e9d5dab7247
Cr-Commit-Position: refs/heads/master@{#303188}

Powered by Google App Engine
This is Rietveld 408576698