Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(878)

Issue 687803003: Update permissions to include all supported domains, and remove externally_connectable. (Closed)

Created:
6 years, 1 month ago by Anand Mistry (off Chromium)
Modified:
6 years, 1 month ago
Reviewers:
rpetterson
CC:
chromium-reviews, rlp+watch_chromium.org, arv+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Update permissions to include all supported domains, and remove externally_connectable. externally_connectable is unused in this extension. BUG=397019 Committed: https://crrev.com/fcd1ac7e25e5af1dd687057ca02c36befabec31d Cr-Commit-Position: refs/heads/master@{#302727}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -7 lines) Patch
M chrome/browser/resources/hotword/manifest.json View 2 chunks +4 lines, -7 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
Anand Mistry (off Chromium)
6 years, 1 month ago (2014-10-29 02:45:37 UTC) #2
Evan Stade
please add an OWNERS file for resources/hotword
6 years, 1 month ago (2014-10-31 21:24:45 UTC) #3
Anand Mistry (off Chromium)
Changed reviewers now that we have OWNERS in resources/hotword.
6 years, 1 month ago (2014-11-03 22:48:20 UTC) #5
rpetterson
LGTM with a question Why doesn't this need the externally connectable any more? I'm happy ...
6 years, 1 month ago (2014-11-04 20:50:45 UTC) #6
Anand Mistry (off Chromium)
On 2014/11/04 20:50:45, rpetterson wrote: > LGTM with a question > > Why doesn't this ...
6 years, 1 month ago (2014-11-05 00:15:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/687803003/1
6 years, 1 month ago (2014-11-05 00:16:57 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-05 01:07:32 UTC) #10
commit-bot: I haz the power
6 years, 1 month ago (2014-11-05 01:08:10 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fcd1ac7e25e5af1dd687057ca02c36befabec31d
Cr-Commit-Position: refs/heads/master@{#302727}

Powered by Google App Engine
This is Rietveld 408576698