Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Issue 687783003: More cleanup of dead code now that we don't have frame-level scrolling. (Closed)

Created:
6 years, 1 month ago by ojan
Modified:
6 years, 1 month ago
Reviewers:
esprehn
CC:
esprehn, abarth-chromium, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

More cleanup of dead code now that we don't have frame-level scrolling. No change in behavior. The overflowchanged event was never fired. R=esprehn@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/df28ca7514d6d3199a5ea22f7e7d0b1fa4773032

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -219 lines) Patch
M sky/engine/core/dom/Document.h View 1 chunk +5 lines, -7 lines 0 comments Download
M sky/engine/core/dom/Document.cpp View 2 chunks +1 line, -10 lines 0 comments Download
M sky/engine/core/frame/FrameView.h View 9 chunks +1 line, -24 lines 0 comments Download
M sky/engine/core/frame/FrameView.cpp View 11 chunks +0 lines, -147 lines 0 comments Download
M sky/engine/core/frame/UseCounter.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/frame/UseCounter.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M sky/engine/core/loader/FrameLoader.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M sky/engine/core/page/scrolling/ScrollingCoordinator.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/page/scrolling/ScrollingCoordinator.cpp View 3 chunks +1 line, -5 lines 0 comments Download
M sky/engine/core/rendering/RenderBox.cpp View 2 chunks +1 line, -8 lines 0 comments Download
M sky/engine/core/rendering/compositing/RenderLayerCompositor.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/rendering/compositing/RenderLayerCompositor.cpp View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
esprehn
lgtm
6 years, 1 month ago (2014-10-28 23:52:50 UTC) #2
ojan
6 years, 1 month ago (2014-10-28 23:53:51 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
df28ca7514d6d3199a5ea22f7e7d0b1fa4773032.

Powered by Google App Engine
This is Rietveld 408576698