Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 687733006: Move getBrowserUserAgent() under ChromiumApplication (Closed)

Created:
6 years, 1 month ago by Jaekyun Seok (inactive)
Modified:
6 years, 1 month ago
Reviewers:
Ted C, Yaron
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Move getBrowserUserAgent() under ChromiumApplication BUG=412156 Committed: https://crrev.com/9b3a011783e559cc9a0fa1c447b5c782af9a142b Cr-Commit-Position: refs/heads/master@{#302021}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ChromiumApplication.java View 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/browser/android/chromium_application.cc View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Jaekyun Seok (inactive)
Please review this change.
6 years, 1 month ago (2014-10-29 02:34:05 UTC) #2
Yaron
lgtm
6 years, 1 month ago (2014-10-29 18:18:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/687733006/1
6 years, 1 month ago (2014-10-30 02:12:45 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-30 02:45:56 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-10-30 02:46:42 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9b3a011783e559cc9a0fa1c447b5c782af9a142b
Cr-Commit-Position: refs/heads/master@{#302021}

Powered by Google App Engine
This is Rietveld 408576698