extensions/browser/api/cast_channel/cast_socket.cc - Issue 687733004: Implement crypto signature verification routines using OpenSSL.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/cast_channel/cast_socket.cc

Issue 687733004: Implement crypto signature verification routines using OpenSSL. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Misc. fixes Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« extensions/browser/api/cast_channel/cast_auth_util_openssl_unittest.cc ('K') | « extensions/browser/api/cast_channel/cast_channel_apitest.cc ('k') | extensions/browser/api/cast_channel/logger.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/cast_channel/cast_socket.cc

diff --git a/extensions/browser/api/cast_channel/cast_socket.cc b/extensions/browser/api/cast_channel/cast_socket.cc

index 83994df6b1c413a28d43401689a4db0c8b973224..95c6f959a847ff7dbb5b276763396641883fe0fb 100644

--- a/extensions/browser/api/cast_channel/cast_socket.cc

+++ b/extensions/browser/api/cast_channel/cast_socket.cc

@@ -177,6 +177,9 @@ bool CastSocket::ExtractPeerCert(std::string* cert) {

bool CastSocket::VerifyChallengeReply() {

AuthResult result = AuthenticateChallengeReply(*challenge_reply_, peer_cert_);

+ if (result.success()) {

mark a. foltz 2014/10/31 22:29:26 Did you intend to submit this change? If so, is er

+ VLOG(1) << result.error_message;

+ }

logger_->LogSocketChallengeReplyEvent(channel_id_, result);

return result.success();

}