Issue 68773005: Disable Blurred RR optimization in Chrome

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 68773005: Disable Blurred RR optimization in Chrome (Closed)

Created:
7 years, 1 month ago by robertphillips

Modified:
7 years, 1 month ago

Reviewers:
scroggo

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

It turned out that r12198 (Add ability to ninepatch blurred rounded rectangle https://codereview.chromium.org/48623006/) is/was causing the Windows-only Chromium crash. The reason is that Chrome has several SkBitmapDevice-derived classes that are now calling SkDraw::drawRRect instead of their own overridden SkDevice::drawPath. The VectorPlatformDeviceEmf was crashing in this case but I believe some more investigation needs to be done r.e. the other Chromium SkBitmapDevice-derived classes before this is turned on.

Patch Set 1 #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -0 lines)			Patch
	M	src/core/SkBitmapDevice.cpp	View		1 chunk	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages