Pepper: Add MonitorIsExternal function to PPB_Flash_DRM.

Pepper: Add MonitorIsExternal function to PPB_Flash_DRM.
This adds the Pepper boilerplate code, including messages,
for implementing a new MonitorIsExternal method. The
implementation in PepperFlashDRMHost is stubbed out.

BUG=none

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=237471

[bbudge, 2013-11-12 00:01:29]

Not really a review, just FYI Carlos.
I still need to implement the Windows version. Unless you want to : )

[cpu_(ooo_6.6-7.5), 2013-11-12 20:14:57]

there is no need for the windows version, but I will do it if 'they' want to.

[yzshen1, 2013-11-19 23:22:59]

drive-by comments, all are nits.

https://codereview.chromium.org/68773004/diff/30001/ppapi/cpp/private/flash_d...
File ppapi/cpp/private/flash_drm.cc (right):

https://codereview.chromium.org/68773004/diff/30001/ppapi/cpp/private/flash_d...
ppapi/cpp/private/flash_drm.cc:16: template <> const char*
interface_name<PPB_Flash_DRM_1_0>() {
We should also have one for PPB_Flash_DRM_1_1?

Besides, shall we update all methods to check PPB_Flash_DRM_1_1 before falling
back to PPB_Flash_DRM_1_0?

https://codereview.chromium.org/68773004/diff/30001/ppapi/proxy/flash_drm_res...
File ppapi/proxy/flash_drm_resource.cc (right):

https://codereview.chromium.org/68773004/diff/30001/ppapi/proxy/flash_drm_res...
ppapi/proxy/flash_drm_resource.cc:86: is_external, callback));
nit: 4 more spaces indent or align with the first param of base::Bind.

[cpu_(ooo_6.6-7.5), 2013-11-20 02:20:25]

lgtm on my side.

[bbudge, 2013-11-25 21:47:59]

+palmer for ppapi_messages.h

https://codereview.chromium.org/68773004/diff/30001/ppapi/cpp/private/flash_d...
File ppapi/cpp/private/flash_drm.cc (right):

https://codereview.chromium.org/68773004/diff/30001/ppapi/cpp/private/flash_d...
ppapi/cpp/private/flash_drm.cc:16: template <> const char*
interface_name<PPB_Flash_DRM_1_0>() {
On 2013/11/19 23:22:59, yzshen1 wrote:
> We should also have one for PPB_Flash_DRM_1_1?
> 
> Besides, shall we update all methods to check PPB_Flash_DRM_1_1 before falling
> back to PPB_Flash_DRM_1_0? 

Done. Good catch.

https://codereview.chromium.org/68773004/diff/30001/ppapi/proxy/flash_drm_res...
File ppapi/proxy/flash_drm_resource.cc (right):

https://codereview.chromium.org/68773004/diff/30001/ppapi/proxy/flash_drm_res...
ppapi/proxy/flash_drm_resource.cc:86: is_external, callback));
On 2013/11/19 23:22:59, yzshen1 wrote:
> nit: 4 more spaces indent or align with the first param of base::Bind.

Done.

[yzshen1, 2013-11-25 22:02:21]

lgtm

[bbudge, 2013-11-26 00:54:58]

jschuh@chromium.org: Please review changes in 

ppapi_messages.h

[jschuh, 2013-11-26 20:53:21]

ipc security lgtm. state request and a bool reply.

[commit-bot: I haz the power, 2013-11-26 21:07:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bbudge@chromium.org/68773004/160001

[commit-bot: I haz the power, 2013-11-26 23:19:36]

Retried try job too often on win_rel for step(s) unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-11-26 23:35:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bbudge@chromium.org/68773004/160001

[commit-bot: I haz the power, 2013-11-27 01:33:40]

Change committed as 237471