Remove executable bit from files which aren't executable

Remove executable bit from files which aren't executable

This has already been done for web-platform-tests, so we shouldn't
get the executable bits back on future imports for those tests:
https://github.com/w3c/web-platform-tests/commit/35c13df5fedbd68dbec5dbb5717cb2f2b2011041

BUG=none
NOTRY=true

[philipj_slow, 2013-11-11 13:55:55]

I'd be somewhat surprised if mode changes will make it through the review
system, commit queue, Subversion and back to Git again, but PTAL anyway.

[eseidel, 2013-11-11 18:43:10]

lgtm

<3

[commit-bot: I haz the power, 2013-11-11 18:43:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/philipj@opera.com/68773002/1

[commit-bot: I haz the power, 2013-11-11 18:43:52]

Can't process patch for file LayoutTests/fast/images/resources/12-55.jpg.
Binary file is empty. Maybe the file wasn't uploaded in the first place?

[commit-bot: I haz the power, 2013-11-11 20:51:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/philipj@opera.com/68773002/90001

[commit-bot: I haz the power, 2013-11-11 20:51:45]

Can't process patch for file LayoutTests/fast/images/resources/12-55.jpg.
Binary file is empty. Maybe the file wasn't uploaded in the first place?

[philipj_slow, 2013-11-11 22:02:31]

On 2013/11/11 20:51:45, I haz the power (commit-bot) wrote:
> Can't process patch for file LayoutTests/fast/images/resources/12-55.jpg.
> Binary file is empty. Maybe the file wasn't uploaded in the first place?

I'm not very surprised that this didn't work. Eric, do you think NOTRY=true is
safe for this, and that it will even get around this problem? I should get my
commit bit soon, so dcommit would also be an option.

[eseidel, 2013-11-11 22:23:03]

I suspect you'll need to do this manually, from an SVN checkout.

Committers are added on Tuesdays, so I'm told you should get your bit tomorrow.

[philipj_slow, 2013-11-12 08:25:09]

On 2013/11/11 22:23:03, eseidel wrote:
> I suspect you'll need to do this manually, from an SVN checkout.
> 
> Committers are added on Tuesdays, so I'm told you should get your bit
tomorrow.

I'll try it with NOTRY=true first, and if that doesn't work do it manually
later.

[commit-bot: I haz the power, 2013-11-12 08:27:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/philipj@opera.com/68773002/90001

[commit-bot: I haz the power, 2013-11-12 08:27:09]

Can't process patch for file LayoutTests/fast/images/resources/12-55.jpg.
Binary file is empty. Maybe the file wasn't uploaded in the first place?

[philipj_slow, 2013-11-13 12:59:14]

Committed manually.

[Nils Barth (inactive), 2013-11-14 03:06:54]

On 2013/11/11 13:55:55, philipj wrote:
> I'd be somewhat surprised if mode changes will make it through the review
> system, commit queue, Subversion and back to Git again, but PTAL anyway.

For reference, CQ does *not* change executable bit;
you always need to dcommit these.
This has happened to me, and I've documented it here:
http://www.chromium.org/developers/contributing-code/direct-commit

The relevant bug is:
Commit queue doesn't change the svn:executable bit
https://code.google.com/p/chromium/issues/detail?id=162196

[Nils Barth (inactive), 2013-11-14 03:08:30]

On 2013/11/13 12:59:14, philipj wrote:
> Committed manually.

?
How did you commit manually?
If you do
git cl dcommit
...which is recommended, and documented at:
http://www.chromium.org/developers/contributing-code/direct-commit
...then it'll automatically add a note and link to the revision here.

Hope this helps!

[philipj_slow, 2013-11-14 07:40:18]

On 2013/11/14 03:08:30, Nils Barth wrote:
> On 2013/11/13 12:59:14, philipj wrote:
> > Committed manually.
> 
> ?
> How did you commit manually?
> If you do
> git cl dcommit
> ...which is recommended, and documented at:
> http://www.chromium.org/developers/contributing-code/direct-commit
> ...then it'll automatically add a note and link to the revision here.
> 
> Hope this helps!

I was aware of git cl dcommit, but I probably misinterpreted what Eric meant by
"manually, from an SVN checkout," so I actually checked out the code using svn,
made my change and committed, trying to emulate the commit message formatting
from CQ. Will use dcommit next time.