Optimize compare_build_artifacts.py to have an even more compact output.

Optimize compare_build_artifacts.py to have an even more compact output.

Unified diff is still too verbose for .isolated comparison. Add byte streams
output for binaries if small enough.

R=sebmarchand@chromium.org
BUG=314403
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=292834

[M-A Ruel, 2014-11-04 20:24:31]

Local output looks like:
$ ./compare_build_artifacts.py -f ~/src/chrome/src/out.3/Release -s
~/src/chrome/src/out/Release
d8                    : equal
genmacro              : equal
genmodule             : equal
genperf               : equal
genstring             : equal
genversion            : equal
libffmpegsumo.so      : equal
libosmesa.so          : equal
libvpx_obj_int_extract: equal
mksnapshot            : equal
nacl_irt_x86_64.nexe  : DIFFERENT: 20 out of 3343720 bytes are different (0.00%)
      480: 36340000040000001400000003000000474e5500e6e223e13fa609529c958c27
           36340000040000001400000003000000474e550015a0b8895ecedc69cf7ba8b4
      512: fc6adf0613afa6ff000000000000000000000000000000000000000000000000
           5f16f28311a44880000000000000000000000000000000000000000000000000
net_unittests         : equal
net_unittests.isolated: equal
protoc                : equal
re2c                  : equal
tls_edit              : equal
unit_tests            : DIFFERENT: 35 out of 191593960 bytes are different
(0.00%)
      672: 020000000600000018000000040000001400000003000000474e55004ac567ce
           020000000600000018000000040000001400000003000000474e55005bac9f76
      704: f31b00b6f4ab92c8563a9f93bcc9b0f700000000000000000000000000000000
           ab6fd5fdfdb861dc8ec6a97a24f0640b00000000000000000000000000000000
110285344: 20696e666f3a202573004f637420333120323031342031393a32343a30302072
           20696e666f3a202573004f637420333120323031342032303a30343a30342072
110360608: 20333120323031342031393a32393a3239207200566f696365456e67696e6520
           20333120323031342032303a31313a3135207200566f696365456e67696e6520
110378144: 31342031393a32393a3335207200566964656f4368616e6e656c206372656174
           31342032303a31313a3336207200566964656f4368616e6e656c206372656174
unit_tests.isolated   : DIFFERENT: 
- files:
    - out/Release/unit_tests:
        - h:
            a0642f76a9f52df3f586b6174bf962bad2276d50 !=
f6022f3ab2df3010efbd21489d5c69ed216581a9
xdisplaycheck         : equal
yasm                  : equal
17 files are equal, 3 are different.


One option would be to have offsets as hex numbers so they wouldn't look as odd.

[Sébastien Marchand, 2014-11-04 20:29:57]

Awesome, thanks for taking care of this !

https://codereview.chromium.org/687723008/diff/1/scripts/slave/recipe_modules...
File scripts/slave/recipe_modules/isolate/resources/compare_build_artifacts.py
(right):

https://codereview.chromium.org/687723008/diff/1/scripts/slave/recipe_modules...
scripts/slave/recipe_modules/isolate/resources/compare_build_artifacts.py:87:
result += ''.join(
Should we also print the ascii representation of those bytes ? (with a  filter
to only print the values that correspond to a valid char),

something like:
46 72 61 6D 65 72 32 39 42 75 69 6C 64 56 65 72 | Framer29BuildVer

[M-A Ruel, 2014-11-04 20:32:23]

New output looks like:

unit_tests            : DIFFERENT: 35 out of 191593960 bytes are different
(0.00%)
0x2a0     : 020000000600000018000000040000001400000003000000474e55004ac567ce
'........................GNU.J.g.'
            020000000600000018000000040000001400000003000000474e55005bac9f76
'........................GNU.[..v'
0x2c0     : f31b00b6f4ab92c8563a9f93bcc9b0f700000000000000000000000000000000
'........V:......................'
            ab6fd5fdfdb861dc8ec6a97a24f0640b00000000000000000000000000000000
'.o....a....z$.d.................'
0x692d220 : 20696e666f3a202573004f637420333120323031342031393a32343a30302072 '
info: %s.Oct 31 2014 19:24:00 r'
            20696e666f3a202573004f637420333120323031342032303a30343a30342072 '
info: %s.Oct 31 2014 20:04:04 r'
0x693f820 : 20333120323031342031393a32393a3239207200566f696365456e67696e6520 '
31 2014 19:29:29 r.VoiceEngine '
            20333120323031342032303a31313a3135207200566f696365456e67696e6520 '
31 2014 20:11:15 r.VoiceEngine '
0x6943ca0 : 31342031393a32393a3335207200566964656f4368616e6e656c206372656174 '14
19:29:35 r.VideoChannel creat'
            31342032303a31313a3336207200566964656f4368616e6e656c206372656174 '14
20:11:36 r.VideoChannel creat'

[Sébastien Marchand, 2014-11-04 20:38:11]

awesome. LGTM.

[M-A Ruel, 2014-11-04 20:51:11]

On 2014/11/04 20:38:11, Sébastien Marchand wrote:
> awesome. LGTM.

Final output looks like:

0x6943ca0 : 31342031393a32393a3335207200566964656f4368616e6e656c206372656174 '14
19:29:35 r.VideoChannel creat'
            31342032303a31313a3336207200566964656f4368616e6e656c206372656174 '14
20:11:36 r.VideoChannel creat'
                   ^ ^   ^ ^     ^                                              
+++ ^  ^

I'll commit this and we can iterate from there if necessary.

[M-A Ruel, 2014-11-04 20:51:14]

The CQ bit was checked by maruel@chromium.org

[commit-bot: I haz the power, 2014-11-04 20:51:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/687723008/40001

[commit-bot: I haz the power, 2014-11-04 20:52:28]

Committed patchset #3 (id:40001) as 292834