Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Issue 687723002: Chromecast: adds platform hooks for initializing client-auth support. (Closed)

Created:
6 years, 1 month ago by gunsch
Modified:
6 years, 1 month ago
Reviewers:
lcwu1, dougsteed
CC:
chromium-reviews, lcwu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Chromecast: adds platform hooks for initializing client-auth support. R=dougsteed@chromium.org,lcwu@chromium.org BUG=336640 Committed: https://crrev.com/64aeb562abb00459d478e472e8302f2bdc2808cc Cr-Commit-Position: refs/heads/master@{#302000}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : Removes unittest support file. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -4 lines) Patch
M chromecast/browser/cast_browser_main_parts.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M chromecast/chromecast.gyp View 2 chunks +2 lines, -0 lines 0 comments Download
A chromecast/common/platform_client_auth.h View 1 chunk +23 lines, -0 lines 0 comments Download
A + chromecast/common/platform_client_auth_simple.cc View 1 chunk +7 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
gunsch
6 years, 1 month ago (2014-10-28 17:49:58 UTC) #1
lcwu1
platform_client_auth_unittest_support.cc is added but not built/used, which usually leads to bit-rot. We should remove it ...
6 years, 1 month ago (2014-10-29 23:21:51 UTC) #2
gunsch
On 2014/10/29 23:21:51, lcwu1 wrote: > platform_client_auth_unittest_support.cc is added but not built/used, which > usually ...
6 years, 1 month ago (2014-10-29 23:59:51 UTC) #3
lcwu1
lgtm
6 years, 1 month ago (2014-10-30 00:02:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/687723002/40001
6 years, 1 month ago (2014-10-30 00:10:37 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years, 1 month ago (2014-10-30 00:57:14 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-10-30 00:57:54 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/64aeb562abb00459d478e472e8302f2bdc2808cc
Cr-Commit-Position: refs/heads/master@{#302000}

Powered by Google App Engine
This is Rietveld 408576698