Issue 687703002: Fix services/network.sky test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 687703002: Fix services/network.sky test (Closed)

Created:
6 years, 1 month ago by abarth-chromium

Modified:
6 years, 1 month ago

Reviewers:
eseidel, ojan

CC:
ojan, mojo-reviews_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Project:
mojo

Visibility:
Public.

Fix services/network.sky test mojo_shell can't handle loading the same DLL from two different URLs. The extra trailing slash was causing us to load the network_service DLL twice. R=ojan@chromium.org, eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/92c481b52f80b3f658376d49ee00bf15e07ad566

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -3 lines)			Patch
	M	sky/tests/TestExpectations	View		1 chunk	+0 lines, -2 lines	0 comments	Download
	M	sky/tests/services/network.sky	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 6 (1 generated)

ojan

lgtm Presumably there is a mojo bug here that should be filed? e.g. why does ...

6 years, 1 month ago (2014-10-28 16:38:46 UTC) #3

abarth-chromium

Committed patchset #1 (id:1) manually as 92c481b52f80b3f658376d49ee00bf15e07ad566 (presubmit successful).

6 years, 1 month ago (2014-10-28 16:56:07 UTC) #4

abarth-chromium

6 years, 1 month ago (2014-10-28 17:56:36 UTC) #6

Message was sent while issue was closed.

On 2014/10/28 at 17:51:01, esprehn wrote:
> Where's the mojo bug?

https://code.google.com/p/chromium/issues/detail?id=427974