Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 687673004: Move framework/inspector/server to services/inspector (Closed)

Created:
6 years, 1 month ago by abarth-chromium
Modified:
6 years, 1 month ago
Reviewers:
eseidel
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, esprehn, yzshen+watch_chromium.org, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, ojan
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Move framework/inspector/server to services/inspector Moving the inspector WebSocket proxy server out of the framework directory simplifies the mappings for the HTTP servers. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/088819dcad2854a35e08f06591433fb3a6a2f93c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -295 lines) Patch
M sky/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
D sky/framework/inspector/BUILD.gn View 1 chunk +0 lines, -24 lines 0 comments Download
M sky/framework/inspector/inspector.sky View 1 chunk +1 line, -1 line 0 comments Download
D sky/framework/inspector/server/BUILD.gn View 1 chunk +0 lines, -37 lines 0 comments Download
D sky/framework/inspector/server/DEPS View 1 chunk +0 lines, -6 lines 0 comments Download
D sky/framework/inspector/server/inspector.mojom View 1 chunk +0 lines, -20 lines 0 comments Download
D sky/framework/inspector/server/inspector_frontend_impl.h View 1 chunk +0 lines, -56 lines 0 comments Download
D sky/framework/inspector/server/inspector_frontend_impl.cc View 1 chunk +0 lines, -97 lines 0 comments Download
D sky/framework/inspector/server/server.cc View 1 chunk +0 lines, -42 lines 0 comments Download
A + sky/services/inspector/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
A + sky/services/inspector/DEPS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/services/inspector/inspector.mojom View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/services/inspector/inspector_frontend_impl.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + sky/services/inspector/inspector_frontend_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
A + sky/services/inspector/server.cc View 1 chunk +1 line, -1 line 0 comments Download
M sky/tools/sky_server View 1 chunk +0 lines, -6 lines 0 comments Download
M sky/tools/webkitpy/layout_tests/servers/apache_http.py View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
abarth-chromium
6 years, 1 month ago (2014-10-28 22:37:12 UTC) #1
eseidel
lgtm
6 years, 1 month ago (2014-10-28 22:37:59 UTC) #3
abarth-chromium
6 years, 1 month ago (2014-10-28 22:38:26 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
088819dcad2854a35e08f06591433fb3a6a2f93c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698