Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 687673003: Add beginnings of an inspector backend for Sky (Closed)

Created:
6 years, 1 month ago by abarth-chromium
Modified:
6 years, 1 month ago
Reviewers:
eseidel
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, esprehn, yzshen+watch_chromium.org, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, ojan
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+521 lines, -16 lines) Patch
M sky/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A sky/framework/inspector/console-agent.sky View 1 chunk +12 lines, -0 lines 0 comments Download
A sky/framework/inspector/dom-agent.sky View 1 chunk +169 lines, -0 lines 0 comments Download
A sky/framework/inspector/inspector.sky View 1 chunk +83 lines, -0 lines 0 comments Download
A sky/framework/inspector/page-agent.sky View 1 chunk +21 lines, -0 lines 0 comments Download
A + sky/framework/inspector/server/BUILD.gn View 1 chunk +8 lines, -16 lines 0 comments Download
A sky/framework/inspector/server/inspector.mojom View 1 chunk +20 lines, -0 lines 0 comments Download
A sky/framework/inspector/server/inspector_frontend_impl.h View 1 chunk +56 lines, -0 lines 0 comments Download
A sky/framework/inspector/server/inspector_frontend_impl.cc View 1 chunk +97 lines, -0 lines 0 comments Download
A sky/framework/inspector/server/server.cc View 1 chunk +42 lines, -0 lines 0 comments Download
A sky/framework/inspector/worker-agent.sky View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
abarth-chromium
6 years, 1 month ago (2014-10-28 17:41:06 UTC) #1
eseidel
lgtm
6 years, 1 month ago (2014-10-28 17:46:21 UTC) #3
abarth-chromium
6 years, 1 month ago (2014-10-28 17:46:51 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0195e01ee21b7d5533d569efef49da041b478ea4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698