Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/junit/BUILD.gn

Issue 687633003: Greatly improve (non-android) java support (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « testing/android/junit/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/junit/BUILD.gn
diff --git a/third_party/junit/BUILD.gn b/third_party/junit/BUILD.gn
index 038e1ac319270f43739d92181d9395e9294fc6b1..33cbb641f339b1524c47aa7711c36c4a078646db 100644
--- a/third_party/junit/BUILD.gn
+++ b/third_party/junit/BUILD.gn
@@ -4,15 +4,13 @@
import("//build/config/android/rules.gni")
-# TODO(GYP): should be java_prebuilt
# GYP: //third_party/junit.gyp:hamcrest_jar
-android_java_prebuilt("hamcrest") {
+java_prebuilt("hamcrest") {
jar_path = "src/lib/hamcrest-core-1.3.jar"
}
-# TODO(GYP): should be java_library
# GYP: //third_party/junit.gyp:junit_jar
-android_library("junit") {
+java_library("junit") {
deps = [
":hamcrest"
]
« no previous file with comments | « testing/android/junit/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698