Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 687633002: MIPS: Classes: Add basic support for properties (Closed)

Created:
6 years, 1 month ago by balazs.kilvady
Modified:
6 years, 1 month ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

MIPS: Classes: Add basic support for properties Port r24934 (279833c) Original commit message: This adds the properties to the prototype and the constructor. BUG=v8:3330 LOG=Y R=paul.lind@imgtec.com Committed: https://code.google.com/p/v8/source/detail?r=24951

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+136 lines, -0 lines) Patch
M src/mips/full-codegen-mips.cc View 1 chunk +68 lines, -0 lines 0 comments Download
M src/mips64/full-codegen-mips64.cc View 1 chunk +68 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
balazs.kilvady
6 years, 1 month ago (2014-10-28 14:14:24 UTC) #2
paul.l...
LGTM.
6 years, 1 month ago (2014-10-28 15:13:12 UTC) #3
balazs.kilvady
Committed patchset #1 (id:1) manually as 24951 (presubmit successful).
6 years, 1 month ago (2014-10-28 15:45:00 UTC) #4
arv (Not doing code reviews)
6 years, 1 month ago (2014-10-28 16:55:14 UTC) #5
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698