Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Issue 68763013: Remove code in gsutil that removes http_proxy from the env var (Closed)

Created:
7 years, 1 month ago by hinoka
Modified:
7 years, 1 month ago
Reviewers:
Ryan Tseng, M-A Ruel
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Visibility:
Public.

Description

Remove code in gsutil that removes http_proxy from the env var boto config does the right thing by using the http_proxy env var to set the proxy, and gsutil removes that var which isn't the behavior we want. This should allow gsutil to respect the http_proxy env var. BUG=318478 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=235818

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -10 lines) Patch
M third_party/gsutil/CHECKSUM View 1 chunk +1 line, -1 line 0 comments Download
M third_party/gsutil/README.chromium View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/gsutil/gsutil View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Ryan Tseng
+maruel review because, depot_tools change. Not entirely sure how to test this without launching a ...
7 years, 1 month ago (2013-11-14 22:12:50 UTC) #1
M-A Ruel
rubberstamp lgtm
7 years, 1 month ago (2013-11-14 22:50:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hinoka@chromium.org/68763013/1
7 years, 1 month ago (2013-11-14 22:53:30 UTC) #3
commit-bot: I haz the power
Presubmit check for 68763013-1 failed and returned exit status 1. Running presubmit commit checks ...
7 years, 1 month ago (2013-11-14 22:55:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hinoka@chromium.org/68763013/1
7 years, 1 month ago (2013-11-18 21:25:26 UTC) #5
commit-bot: I haz the power
7 years, 1 month ago (2013-11-18 21:27:02 UTC) #6
Message was sent while issue was closed.
Change committed as 235818

Powered by Google App Engine
This is Rietveld 408576698