Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issue 68763004: my_activity: Skip Rietveld cookie check if not found. (Closed)

Created:
7 years, 1 month ago by deymo
Modified:
6 years, 10 months ago
Reviewers:
cjhopman, szager1
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org, cmp
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Visibility:
Public.

Description

my_activity: Skip Rietveld cookie check if not found. ChromiumOS only developers don't always have a Chromium checkout and a Rietveld cookie file (~/.codereview_upload_cookies) with the auth keys. This patch proceeds with the activity lookup from other services such as Gerrit and GoB if there's no Rietveld cookie present, displaying an error message when this happens. BUG=chromium:316961 TEST=Remove ~/.codereview_upload_cookies and ran my_activity. ChromeOS activity listed. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=234874

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -8 lines) Patch
M my_activity.py View 1 chunk +10 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
deymo
This is a fix for ChromeOS only users reported by two users. Apparently we silently ...
7 years, 1 month ago (2013-11-12 01:02:43 UTC) #1
deymo
Yet another daily friendly ping. =)
7 years, 1 month ago (2013-11-13 01:17:20 UTC) #2
cjhopman
lgtm
7 years, 1 month ago (2013-11-13 01:31:37 UTC) #3
szager1
Sorry! This got buried in my inbox. lgtm
7 years, 1 month ago (2013-11-13 19:05:29 UTC) #4
deymo
On 2013/11/13 19:05:29, szager1 wrote: > Sorry! This got buried in my inbox. > > ...
7 years, 1 month ago (2013-11-13 19:31:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/deymo@chromium.org/68763004/1
7 years, 1 month ago (2013-11-13 19:31:33 UTC) #6
commit-bot: I haz the power
7 years, 1 month ago (2013-11-13 19:33:28 UTC) #7
Message was sent while issue was closed.
Change committed as 234874

Powered by Google App Engine
This is Rietveld 408576698