Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 687573003: cc: Invalidate eviction cache in cases where we remove/add tiles. (Closed)

Created:
6 years, 1 month ago by vmpstr
Modified:
6 years, 1 month ago
Reviewers:
danakj, reveman
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

cc: Invalidate eviction cache in cases where we remove/add tiles. This patch adds more eviction cache invalidations in order to avoid use after free scenarios. This problem will be fixed by faster eviction since we won't need the cache, but until that is in place, this is a necessary fix. BUG=429201 R=danakj, reveman Committed: https://crrev.com/e0b723c4ffc47e8bf4242b8713b74c0005ecd6e8 Cr-Commit-Position: refs/heads/master@{#302393}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M cc/resources/picture_layer_tiling.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M cc/resources/picture_layer_tiling_unittest.cc View 1 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
vmpstr
ptal
6 years, 1 month ago (2014-11-01 01:47:22 UTC) #1
reveman
lgtm
6 years, 1 month ago (2014-11-01 12:31:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/687573003/20001
6 years, 1 month ago (2014-11-01 18:09:42 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-11-01 19:45:35 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-11-01 19:46:14 UTC) #6
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e0b723c4ffc47e8bf4242b8713b74c0005ecd6e8
Cr-Commit-Position: refs/heads/master@{#302393}

Powered by Google App Engine
This is Rietveld 408576698