Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Unified Diff: Source/bindings/core/v8/custom/V8FileCustom.cpp

Issue 687573002: Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/We… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/core/v8/custom/V8BlobCustomHelpers.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/core/v8/custom/V8FileCustom.cpp
diff --git a/Source/bindings/core/v8/custom/V8FileCustom.cpp b/Source/bindings/core/v8/custom/V8FileCustom.cpp
index 8ea060e82c2e2f2e7a23d945e6e2c6f8c7dfde6e..544da6129bfa8385ab9c57b48fb493fc39f4d10c 100644
--- a/Source/bindings/core/v8/custom/V8FileCustom.cpp
+++ b/Source/bindings/core/v8/custom/V8FileCustom.cpp
@@ -63,7 +63,7 @@ void V8File::constructorCustom(const v8::FunctionCallbackInfo<v8::Value>& info)
return;
}
- if (!properties.parseBlobPropertyBag(info[2], "File", exceptionState, info.GetIsolate())) {
+ if (!properties.parseBlobPropertyBag(info.GetIsolate(), info[2], "File", exceptionState)) {
exceptionState.throwIfNeeded();
return;
}
@@ -74,7 +74,7 @@ void V8File::constructorCustom(const v8::FunctionCallbackInfo<v8::Value>& info)
OwnPtr<BlobData> blobData = BlobData::create();
blobData->setContentType(properties.contentType());
v8::Local<v8::Object> blobParts = v8::Local<v8::Object>::Cast(info[0]);
- if (!V8BlobCustomHelpers::processBlobParts(blobParts, properties.normalizeLineEndingsToNative(), *blobData, info.GetIsolate()))
+ if (!V8BlobCustomHelpers::processBlobParts(info.GetIsolate(), blobParts, properties.normalizeLineEndingsToNative(), *blobData))
return;
long long fileSize = blobData->length();
« no previous file with comments | « Source/bindings/core/v8/custom/V8BlobCustomHelpers.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698