Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1277)

Issue 687553006: Get rid of ScrollbarGroup. Sky doesn't use it. (Closed)

Created:
6 years, 1 month ago by ojan
Modified:
6 years, 1 month ago
Reviewers:
esprehn
CC:
esprehn, abarth-chromium, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Get rid of ScrollbarGroup. Sky doesn't use it. More cleanup of dead code now that we don't have frame-level scrolling. R=esprehn@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/f20391035c1dbb2a19cd685dcc2af9bc48dbf1a3

Patch Set 1 #

Patch Set 2 : merge to ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -240 lines) Patch
M sky/engine/web/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D sky/engine/web/ScrollbarGroup.h View 1 chunk +0 lines, -77 lines 0 comments Download
D sky/engine/web/ScrollbarGroup.cpp View 1 chunk +0 lines, -161 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
ojan
6 years, 1 month ago (2014-10-28 23:58:16 UTC) #2
esprehn
lgtm
6 years, 1 month ago (2014-10-29 00:08:27 UTC) #3
ojan
6 years, 1 month ago (2014-10-29 00:37:35 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
f20391035c1dbb2a19cd685dcc2af9bc48dbf1a3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698