Issue 687553006: Get rid of ScrollbarGroup. Sky doesn't use it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 687553006: Get rid of ScrollbarGroup. Sky doesn't use it. (Closed)

Created:
6 years, 1 month ago by ojan

Modified:
6 years, 1 month ago

Reviewers:
esprehn

CC:
esprehn, abarth-chromium, mojo-reviews_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Project:
mojo

Visibility:
Public.

Get rid of ScrollbarGroup. Sky doesn't use it. More cleanup of dead code now that we don't have frame-level scrolling. R=esprehn@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/f20391035c1dbb2a19cd685dcc2af9bc48dbf1a3

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -240 lines)			Patch
M	sky/engine/web/BUILD.gn	View	1 chunk	+0 lines, -2 lines	0 comments	Download
D	sky/engine/web/ScrollbarGroup.h	View	1 chunk	+0 lines, -77 lines	0 comments	Download
D	sky/engine/web/ScrollbarGroup.cpp	View	1 chunk	+0 lines, -161 lines	0 comments	Download

Total messages: 4 (1 generated)

ojan

6 years, 1 month ago (2014-10-29 00:37:35 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
f20391035c1dbb2a19cd685dcc2af9bc48dbf1a3 (presubmit successful).