Issue 687553002: Silence control reducer tracing a bit.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 687553002: Silence control reducer tracing a bit. (Closed)

Created:
6 years, 1 month ago by Michael Starzinger

Modified:
6 years, 1 month ago

Reviewers:
titzer

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Silence control reducer tracing a bit. R=titzer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24936

Patch Set 2 : Addressed comments by Ben Titzer. #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -3 lines)			Patch
	M	src/compiler/control-reducer.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
	M	src/flag-definitions.h	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

titzer

https://codereview.chromium.org/687553002/diff/1/src/flag-definitions.h File src/flag-definitions.h (right): https://codereview.chromium.org/687553002/diff/1/src/flag-definitions.h#newcode358 src/flag-definitions.h:358: DEFINE_BOOL(trace_turbo_control_reducer, false, trace_turbo_reduction ? then we can use this ...

6 years, 1 month ago (2014-10-28 12:16:34 UTC) #2

Michael Starzinger

6 years, 1 month ago (2014-10-28 12:38:15 UTC) #3

Michael Starzinger

6 years, 1 month ago (2014-10-28 13:15:06 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as 24936 (presubmit successful).

Expand Messages | Collapse Messages

Issue 687553002: Silence control reducer tracing a bit. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Addressed comments by Ben Titzer. #

Messages