Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 687553002: Silence control reducer tracing a bit. (Closed)

Created:
6 years, 1 month ago by Michael Starzinger
Modified:
6 years, 1 month ago
Reviewers:
titzer
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Silence control reducer tracing a bit. R=titzer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24936

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comments by Ben Titzer. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M src/compiler/control-reducer.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/flag-definitions.h View 1 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Michael Starzinger
6 years, 1 month ago (2014-10-28 12:10:48 UTC) #1
titzer
https://codereview.chromium.org/687553002/diff/1/src/flag-definitions.h File src/flag-definitions.h (right): https://codereview.chromium.org/687553002/diff/1/src/flag-definitions.h#newcode358 src/flag-definitions.h:358: DEFINE_BOOL(trace_turbo_control_reducer, false, trace_turbo_reduction ? then we can use this ...
6 years, 1 month ago (2014-10-28 12:16:34 UTC) #2
Michael Starzinger
https://codereview.chromium.org/687553002/diff/1/src/flag-definitions.h File src/flag-definitions.h (right): https://codereview.chromium.org/687553002/diff/1/src/flag-definitions.h#newcode358 src/flag-definitions.h:358: DEFINE_BOOL(trace_turbo_control_reducer, false, On 2014/10/28 12:16:34, titzer wrote: > trace_turbo_reduction ...
6 years, 1 month ago (2014-10-28 12:38:15 UTC) #3
titzer
lgtm
6 years, 1 month ago (2014-10-28 12:45:06 UTC) #4
Michael Starzinger
6 years, 1 month ago (2014-10-28 13:15:06 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 24936 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698