Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 687533002: Print activity state when Ctrl+Shift+Alt+W is pressed (Closed)

Created:
6 years, 1 month ago by hashimoto
Modified:
6 years, 1 month ago
Reviewers:
oshima, sky
CC:
chromium-reviews, Mr4D (OOO till 08-26)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Print activity state when Ctrl+Shift+Alt+W is pressed This should be useful when debugging resource management. BUG=None TBR=sky@chromium.org as an owner of new DEPS dependency ui/wm/public Committed: https://crrev.com/999736ca77e02f4cb62b4a0c6b1739ffde7c2988 Cr-Commit-Position: refs/heads/master@{#302029}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Move debug accelerators to DebugAcceleratorHandler #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -96 lines) Patch
M athena/main/DEPS View 1 1 chunk +1 line, -0 lines 0 comments Download
M athena/main/athena_launcher.cc View 1 3 chunks +5 lines, -0 lines 0 comments Download
M athena/main/athena_main.gyp View 1 1 chunk +2 lines, -0 lines 0 comments Download
A athena/main/debug_accelerator_handler.h View 1 1 chunk +36 lines, -0 lines 0 comments Download
A + athena/main/debug_accelerator_handler.cc View 1 6 chunks +17 lines, -31 lines 0 comments Download
M athena/screen/screen_accelerator_handler.h View 1 2 chunks +1 line, -7 lines 0 comments Download
M athena/screen/screen_accelerator_handler.cc View 1 3 chunks +2 lines, -57 lines 0 comments Download
M athena/screen/screen_manager_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (7 generated)
hashimoto
The output looks like: [25313:25313:1028/191921:ERROR:screen_accelerator_handler.cc(81)] RootWindow : RootWindow (0x2571c32c5620) type=0 visible 0,0 1280x720 AthenaBackground (0x2571c32c5ba0) ...
6 years, 1 month ago (2014-10-28 10:21:27 UTC) #2
oshima
https://codereview.chromium.org/687533002/diff/1/athena/screen/screen_accelerator_handler.cc File athena/screen/screen_accelerator_handler.cc (right): https://codereview.chromium.org/687533002/diff/1/athena/screen/screen_accelerator_handler.cc#newcode8 athena/screen/screen_accelerator_handler.cc:8: #include "athena/activity/public/activity_manager.h" ugh, screen shouldn't depend no activity. adding ...
6 years, 1 month ago (2014-10-28 16:39:03 UTC) #3
hashimoto
https://codereview.chromium.org/687533002/diff/1/athena/screen/screen_accelerator_handler.cc File athena/screen/screen_accelerator_handler.cc (right): https://codereview.chromium.org/687533002/diff/1/athena/screen/screen_accelerator_handler.cc#newcode8 athena/screen/screen_accelerator_handler.cc:8: #include "athena/activity/public/activity_manager.h" On 2014/10/28 16:39:02, oshima wrote: > ugh, ...
6 years, 1 month ago (2014-10-29 04:57:36 UTC) #6
oshima
lgtm
6 years, 1 month ago (2014-10-29 14:57:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/687533002/60001
6 years, 1 month ago (2014-10-30 03:28:49 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/21148)
6 years, 1 month ago (2014-10-30 03:32:26 UTC) #11
hashimoto
TBRing sky@chromium.org as an owner of new DEPS dependency ui/wm/public
6 years, 1 month ago (2014-10-30 03:36:02 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/687533002/60001
6 years, 1 month ago (2014-10-30 03:36:52 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:60001)
6 years, 1 month ago (2014-10-30 04:09:47 UTC) #16
commit-bot: I haz the power
6 years, 1 month ago (2014-10-30 04:10:35 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/999736ca77e02f4cb62b4a0c6b1739ffde7c2988
Cr-Commit-Position: refs/heads/master@{#302029}

Powered by Google App Engine
This is Rietveld 408576698