Issue 6875024: net: Put net/server/* into namespace net.

Issue 6875024: net: Put net/server/* into namespace net. (Closed)

Created:
9 years, 8 months ago by tfarina

Modified:
9 years, 7 months ago

Reviewers:
willchan no longer on Chromium

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

net: Put net/server/* into namespace net. BUG=64263 TEST=None R=willchan@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=81921

Patch Set 2 : willchan review #

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+54 lines, -37 lines)			Patch
M	chrome/browser/debugger/devtools_http_protocol_handler.h	View		3 chunks	+9 lines, -9 lines	0 comments	Download
M	chrome/browser/debugger/devtools_http_protocol_handler.cc	View		13 chunks	+16 lines, -16 lines	0 comments	Download
M	net/server/http_server.h	View		2 chunks	+4 lines, -0 lines	0 comments	Download
M	net/server/http_server.cc	View	1	3 chunks	+14 lines, -9 lines	0 comments	Download
M	net/server/http_server_request_info.h	View		3 chunks	+6 lines, -2 lines	0 comments	Download
M	net/server/http_server_request_info.cc	View		1 chunk	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

willchan no longer on Chromium

LGTM mod my header ordering nit. Thanks for the cleanup! http://codereview.chromium.org/6875024/diff/1/net/server/http_server.cc File net/server/http_server.cc (right): http://codereview.chromium.org/6875024/diff/1/net/server/http_server.cc#newcode9 ...

9 years, 8 months ago (2011-04-17 17:30:00 UTC) #2

tfarina

9 years, 8 months ago (2011-04-18 00:17:15 UTC) #3

http://codereview.chromium.org/6875024/diff/1/net/server/http_server.cc
File net/server/http_server.cc (right):

http://codereview.chromium.org/6875024/diff/1/net/server/http_server.cc#newcode9
net/server/http_server.cc:9: #include "build/build_config.h"
On 2011/04/17 17:30:00, willchan wrote:
> I believe
> http://dev.chromium.org/developers/coding-style#TOC-Platform-specific-code
> implies that we should put "build/build_config.h" in the normal location and
> move this platform specific include after all the others. I think that applies
> even though these are system headers, which normally should be ahead of
chromium
> project specific headers.

Yup, fixed.

Expand Messages | Collapse Messages