Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 6875020: factory_test_tools: fix results for HWQual tests (Closed)

Created:
9 years, 8 months ago by Hung-Te
Modified:
9 years, 7 months ago
Reviewers:
Tom Wai-Hong Tam
CC:
chromium-os-reviews_chromium.org
Visibility:
Public.

Description

factory_test_tools: fix results for HWQual tests - HWQual needs to allow legacy search when there's still possible case of '' (not present), which were not allowed by gft_hwcomp. This CL removes 'not present' before checking legacy search - HWQual needs to also get better error output messages, especially when above change is applied. BUG=chrome-os-partner:3195 TEST=/gft_hwcomp.py approved_components # on system with / without approved 3G, seeing success # on incompatible system, seeing message like: {'part_id_cardreader': ['Actual: Not Present', 'Expected: XXXX:0138'], 'part_id_ethernet': ['Actual: 0b95:7720 ASIX Elec. Corp. AX88x72A', 'Expected: XXXX:1063 | Not Present']} Change-Id: Ie20111d33a4ca8e1d7743ea5bbb98cb6a8b047d4 R=waihong@chromium.org Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=d667460

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -6 lines) Patch
M gft_hwcomp.py View 4 chunks +19 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Hung-Te
9 years, 8 months ago (2011-04-16 03:47:51 UTC) #1
Tom Wai-Hong Tam
9 years, 8 months ago (2011-04-19 03:35:38 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698