Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Issue 687453007: Suppress misplacedTypeAnnotation to compile cr.defineProperty with annotation. (Closed)

Created:
6 years, 1 month ago by fukino
Modified:
6 years, 1 month ago
Reviewers:
Dan Beam
CC:
chromium-reviews, vitalyp+closure_chromium.org, dbeam+watch-closure_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Suppress misplacedTypeAnnotation to compile cr.defineProperty with annotation. /** @type {number} */ cr.defineProperty(a, 'c'); doesn't compile because of the warning misplacedTypeAnnotation. As the warning is from parser, it can not be suppressed by @suppress tag. So this CL suppress the warning by compile option. BUG=421562 Committed: https://crrev.com/53cb928e457a94a94622ec4e4b77083038092a54 Cr-Commit-Position: refs/heads/master@{#302223}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M third_party/closure_compiler/checker.py View 3 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
fukino
The another option to work around the warning is, as mentioned in #3 in the ...
6 years, 1 month ago (2014-10-30 04:24:10 UTC) #2
Dan Beam
lgtm
6 years, 1 month ago (2014-10-30 18:56:15 UTC) #3
fukino
On 2014/10/30 18:56:15, Dan Beam wrote: > lgtm Thanks!
6 years, 1 month ago (2014-10-31 03:55:44 UTC) #4
fukino
On 2014/10/30 18:56:15, Dan Beam wrote: > lgtm Thanks!
6 years, 1 month ago (2014-10-31 03:55:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/687453007/1
6 years, 1 month ago (2014-10-31 03:56:19 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-31 04:56:13 UTC) #8
commit-bot: I haz the power
6 years, 1 month ago (2014-10-31 04:56:54 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/53cb928e457a94a94622ec4e4b77083038092a54
Cr-Commit-Position: refs/heads/master@{#302223}

Powered by Google App Engine
This is Rietveld 408576698