Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Issue 687413002: Add app_installer to chrome_official_builder. (Closed)

Created:
6 years, 1 month ago by jackhou1
Modified:
6 years, 1 month ago
Reviewers:
sky
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, grt (UTC plus 2)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add app_installer to chrome_official_builder. BUG=341353 Committed: https://crrev.com/1d14cb86bd7d055d4624e7091f6d7d972d781eff Cr-Commit-Position: refs/heads/master@{#302031}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M build/all.gyp View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jackhou1
sky, could you take a look as grt is OOO. This should have app_installer building ...
6 years, 1 month ago (2014-10-30 00:54:54 UTC) #2
sky
LGTM
6 years, 1 month ago (2014-10-30 03:19:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/687413002/1
6 years, 1 month ago (2014-10-30 03:22:46 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-30 04:17:26 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-10-30 04:18:08 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1d14cb86bd7d055d4624e7091f6d7d972d781eff
Cr-Commit-Position: refs/heads/master@{#302031}

Powered by Google App Engine
This is Rietveld 408576698