Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 687363003: Run canvas layout tests with display lists enabled (Closed)

Created:
6 years, 1 month ago by Justin Novosad
Modified:
6 years, 1 month ago
Reviewers:
Stephen White
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

Run canvas layout tests with display lists enabled BUG=386601 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184812

Patch Set 1 #

Patch Set 2 : added rebaseline #

Total comments: 1

Patch Set 3 : adjusted expectations #

Patch Set 4 : added rebaseline #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -3 lines) Patch
M LayoutTests/TestExpectations View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M LayoutTests/VirtualTestSuites View 1 1 chunk +10 lines, -0 lines 0 comments Download
A LayoutTests/virtual/display_list_2d_canvas/canvas/philip/README.txt View 1 chunk +1 line, -0 lines 0 comments Download
A LayoutTests/virtual/display_list_2d_canvas/fast/canvas/README.txt View 1 chunk +1 line, -0 lines 0 comments Download
A + LayoutTests/virtual/display_list_2d_canvas/fast/canvas/canvas-lost-gpu-context-expected.txt View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (5 generated)
Justin Novosad
PTAL
6 years, 1 month ago (2014-10-29 21:19:55 UTC) #2
Stephen White
What's the runtime of this new virtual suite?
6 years, 1 month ago (2014-10-29 21:28:50 UTC) #3
Justin Novosad
On 2014/10/29 21:28:50, Stephen White wrote: > What's the runtime of this new virtual suite? ...
6 years, 1 month ago (2014-10-29 23:07:05 UTC) #4
Justin Novosad
Done. This patch should be good to go now.
6 years, 1 month ago (2014-10-30 15:48:03 UTC) #5
Stephen White
LGTM https://codereview.chromium.org/687363003/diff/20001/LayoutTests/TestExpectations File LayoutTests/TestExpectations (right): https://codereview.chromium.org/687363003/diff/20001/LayoutTests/TestExpectations#newcode379 LayoutTests/TestExpectations:379: crbug.com/428467 virtual/display_list_2d_canvas/fast/canvas/canvas-createImageBitmap-invalid-args.html [ Failure ] Does this still ...
6 years, 1 month ago (2014-10-30 16:01:55 UTC) #6
Justin Novosad
On 2014/10/30 16:01:55, Stephen White wrote: > LGTM > > https://codereview.chromium.org/687363003/diff/20001/LayoutTests/TestExpectations > File LayoutTests/TestExpectations (right): ...
6 years, 1 month ago (2014-10-30 16:03:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/687363003/40001
6 years, 1 month ago (2014-10-30 16:04:53 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/687363003/60001
6 years, 1 month ago (2014-10-30 17:22:01 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/34436)
6 years, 1 month ago (2014-10-30 19:38:57 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/687363003/60001
6 years, 1 month ago (2014-11-04 00:22:04 UTC) #15
commit-bot: I haz the power
6 years, 1 month ago (2014-11-04 00:58:55 UTC) #16
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as 184812

Powered by Google App Engine
This is Rietveld 408576698