Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 687353004: Spoken Feedback Browsertests: ChromeOS UI tests (Closed)

Created:
6 years, 1 month ago by kathrelkeld
Modified:
6 years, 1 month ago
Reviewers:
dmazzoni
CC:
chromium-reviews, oshima+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, yuzo+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Spoken Feedback Browsertests: ChromeOS UI tests Tests for some of the ChromeOS UI elements, including: - shelf and app launcher - system tray - volume/brightness sliders - notifications - overlay mode BUG=None TEST=this Committed: https://crrev.com/55ef2cde8182e4307a50480aec7fc223e8c48a7f Cr-Commit-Position: refs/heads/master@{#302228}

Patch Set 1 #

Patch Set 2 : trybot fix #

Patch Set 3 : remove notifications test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -1 line) Patch
M chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc View 1 2 1 chunk +96 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
kathrelkeld
6 years, 1 month ago (2014-10-30 18:28:24 UTC) #2
dmazzoni
lgtm Fantastic! This covers a lot of features!
6 years, 1 month ago (2014-10-31 04:39:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/687353004/40001
6 years, 1 month ago (2014-10-31 04:40:11 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years, 1 month ago (2014-10-31 05:21:08 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-10-31 05:21:49 UTC) #7
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/55ef2cde8182e4307a50480aec7fc223e8c48a7f
Cr-Commit-Position: refs/heads/master@{#302228}

Powered by Google App Engine
This is Rietveld 408576698