Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 687343003: clang/win: Turn off Winconsistent-missing-override for now. (Closed)

Created:
6 years, 1 month ago by Nico
Modified:
6 years, 1 month ago
Reviewers:
Reid Kleckner, hans
CC:
chromium-reviews, Timur Iskhodzhanov
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

clang/win: Turn off Winconsistent-missing-override for now. We can't fix all instances of this warning at the moment (because of gmock and because of blink apis, see bug). We've fixed many, but our bots still show almost 20k warnings due to this warning, most of them in v8. That's already fixed upstream, but v8 rolls don't happen often. Turn the warning off for now. BUG=428099 NOTRY=true Committed: https://crrev.com/42c03079517c6b0ea14b0427ccd276157b1bef45 Cr-Commit-Position: refs/heads/master@{#302356}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M build/common.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Nico
6 years, 1 month ago (2014-10-31 23:32:36 UTC) #2
Reid Kleckner
lgtm Thanks for investigating the reports!
6 years, 1 month ago (2014-10-31 23:50:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/687343003/1
6 years, 1 month ago (2014-10-31 23:51:54 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-31 23:52:35 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/42c03079517c6b0ea14b0427ccd276157b1bef45 Cr-Commit-Position: refs/heads/master@{#302356}
6 years, 1 month ago (2014-10-31 23:53:19 UTC) #7
hans
6 years, 1 month ago (2014-11-03 12:40:31 UTC) #9
Message was sent while issue was closed.
Users trying to reproduce Win ASan failures locally are now getting build
warnings about unknown option -Wno-inconsistent-missing-override, because they
get an older Clang version (r220557 atm) that doesn't have that flag :/

Timur: maybe we can just bump the Win-ASan version to fix this?

Powered by Google App Engine
This is Rietveld 408576698