Source/bindings/scripts/unstable/v8_interface.py - Issue 68733006: IDL compiler: Refactor attribute configuration from Python CG to Jinja template

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/unstable/v8_interface.py

Issue 68733006: IDL compiler: Refactor attribute configuration from Python CG to Jinja template (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Tweak Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/bindings/scripts/unstable/v8_attributes.py ('k') | Source/bindings/templates/interface.cpp » ('j') | Source/bindings/templates/interface.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/scripts/unstable/v8_interface.py

diff --git a/Source/bindings/scripts/unstable/v8_interface.py b/Source/bindings/scripts/unstable/v8_interface.py

index 08dbdfedcf0eaba60ffebb35e3a483661f2348bb..467f3b69ee921235524952ca4ad7eac57fa13166 100644

--- a/Source/bindings/scripts/unstable/v8_interface.py

+++ b/Source/bindings/scripts/unstable/v8_interface.py

@@ -82,7 +82,7 @@ def generate_interface(interface):

for attribute in interface.attributes]

template_contents.update({

'attributes': attributes,

- 'has_constructor_attributes': any(attribute['is_constructor'] for attribute in attributes),

+ 'has_constructor_attributes': any(attribute['constructor_type'] for attribute in attributes),

'has_per_context_enabled_attributes': any(attribute['per_context_enabled_function_name'] for attribute in attributes),

'has_replaceable_attributes': any(attribute['is_replaceable'] for attribute in attributes),

'has_runtime_enabled_attributes': any(attribute['runtime_enabled_function_name'] for attribute in attributes),

« no previous file with comments | « Source/bindings/scripts/unstable/v8_attributes.py ('k') | Source/bindings/templates/interface.cpp » ('j') | Source/bindings/templates/interface.cpp » ('J')