IDL compiler: Refactor attribute configuration from Python CG to Jinja template

IDL compiler: Refactor attribute configuration from Python CG to Jinja template

Most of the attribute configuration is simple enough to compute in the
templates (via {% set %}), which avoids having to look back and forth
between the template and Python code to figure out what's going on.
This reduces the complexity of the CG, and puts the logic right where
it's actually being used.

setter_callback_name in the one exception -- it's complex and going
to get more complex when we support [PutForwards].

This also makes the naming clearer, as it's all lined up, and makes the
actual attribute line more legible without all the |attribute.| noise.

BUG=239771
NOTRY=true

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162078

[Nils Barth (inactive), 2013-11-15 05:13:34]

Refactoring to reduce indirection and flatten logic,
putting simple configuration logic right where it's used.

Also a question on desc->SetNativeDataProperty.

https://codereview.chromium.org/68733006/diff/30001/Source/bindings/templates...
File Source/bindings/templates/interface.cpp (right):

https://codereview.chromium.org/68733006/diff/30001/Source/bindings/templates...
Source/bindings/templates/interface.cpp:15: {% set setter_callback_name =
attribute.setter_callback_name %}
For consistency -- otherwise it's a bit weird b/c it's missing for this list
and then longer below.

https://codereview.chromium.org/68733006/diff/30001/Source/bindings/templates...
Source/bindings/templates/interface.cpp:34: {% set callback_name =
Again, consistency, and easier to read b/c not inline.

https://codereview.chromium.org/68733006/diff/30001/Source/bindings/templates...
Source/bindings/templates/interface.cpp:180:
desc->SetNativeDataProperty(v8::String::NewSymbol("{{attribute.name}}"),
{{getter_callback_name}}, {{attribute.setter_callback_name}},
v8::External::New(0), static_cast<v8::PropertyAttribute>(v8::None),
v8::Handle<v8::AccessorSignature>(),
static_cast<v8::AccessControl>(v8::DEFAULT));
This ->SetNativeDataProperty call seems a bit suspicious;
should we be able to move this into a proper function call in
V8DOMConfiguration.cpp ?
(That would reduce the configuration/installation duplication some too.)

[haraken, 2013-11-15 06:16:59]

LGTM

https://codereview.chromium.org/68733006/diff/30001/Source/bindings/templates...
File Source/bindings/templates/interface.cpp (right):

https://codereview.chromium.org/68733006/diff/30001/Source/bindings/templates...
Source/bindings/templates/interface.cpp:34: {% set callback_name =

callback_name => method_callback_name

https://codereview.chromium.org/68733006/diff/30001/Source/bindings/templates...
Source/bindings/templates/interface.cpp:180:
desc->SetNativeDataProperty(v8::String::NewSymbol("{{attribute.name}}"),
{{getter_callback_name}}, {{attribute.setter_callback_name}},
v8::External::New(0), static_cast<v8::PropertyAttribute>(v8::None),
v8::Handle<v8::AccessorSignature>(),
static_cast<v8::AccessControl>(v8::DEFAULT));
On 2013/11/15 05:13:34, Nils Barth wrote:
> This ->SetNativeDataProperty call seems a bit suspicious;
> should we be able to move this into a proper function call in
> V8DOMConfiguration.cpp ?
> (That would reduce the configuration/installation duplication some too.)

Yes, we should move all {Function,Object}Template::SetXXX methods into
V8DOMConfiguration.

[Nils Barth (inactive), 2013-11-15 06:26:49]

Thanks, will do SetXXX methods in followup.

https://codereview.chromium.org/68733006/diff/30001/Source/bindings/templates...
File Source/bindings/templates/interface.cpp (right):

https://codereview.chromium.org/68733006/diff/30001/Source/bindings/templates...
Source/bindings/templates/interface.cpp:34: {% set callback_name =
On 2013/11/15 06:17:00, haraken wrote:
> callback_name => method_callback_name

Done.

https://codereview.chromium.org/68733006/diff/30001/Source/bindings/templates...
Source/bindings/templates/interface.cpp:180:
desc->SetNativeDataProperty(v8::String::NewSymbol("{{attribute.name}}"),
{{getter_callback_name}}, {{attribute.setter_callback_name}},
v8::External::New(0), static_cast<v8::PropertyAttribute>(v8::None),
v8::Handle<v8::AccessorSignature>(),
static_cast<v8::AccessControl>(v8::DEFAULT));
On 2013/11/15 06:17:00, haraken wrote:
> Yes, we should move all {Function,Object}Template::SetXXX methods into
> V8DOMConfiguration.

Got it, will do.

[commit-bot: I haz the power, 2013-11-15 06:27:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nbarth@chromium.org/68733006/30002

[commit-bot: I haz the power, 2013-11-15 06:55:44]

Change committed as 162078