Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(834)

Issue 68733003: Fix BaseBubbleController default behavior. (Closed)

Created:
7 years, 1 month ago by groby-ooo-7-16
Modified:
7 years, 1 month ago
Reviewers:
Robert Sesek
CC:
chromium-reviews
Visibility:
Public.

Description

Fix BaseBubbleController default behavior. Since BaseBubbleController does not have a designated initializer, all initializers must set |shouldCloseOnResignKey_| to YES. BUG=317459 R=rsesek@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=234688

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/ui/cocoa/base_bubble_controller.mm View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
groby-ooo-7-16
Episode 2, wherein we curse the lack of a designated initializer... PTAL
7 years, 1 month ago (2013-11-11 19:58:42 UTC) #1
Robert Sesek
LGTM
7 years, 1 month ago (2013-11-11 20:04:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/groby@chromium.org/68733003/1
7 years, 1 month ago (2013-11-11 20:18:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/groby@chromium.org/68733003/1
7 years, 1 month ago (2013-11-12 20:57:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/groby@chromium.org/68733003/1
7 years, 1 month ago (2013-11-12 23:53:47 UTC) #5
commit-bot: I haz the power
7 years, 1 month ago (2013-11-13 01:00:19 UTC) #6
Message was sent while issue was closed.
Change committed as 234688

Powered by Google App Engine
This is Rietveld 408576698