Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 687323003: Adds a Training Manager to the hotword extension. (Closed)

Created:
6 years, 1 month ago by kcarattini
Modified:
6 years, 1 month ago
CC:
rpetterson, chromium-reviews, chromium-apps-reviews_chromium.org, rlp+watch_chromium.org, arv+watch_chromium.org, extensions-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@tp3-api
Project:
chromium
Visibility:
Public.

Description

Adds a Training Manager to the hotword extension. BUG=397019 Committed: https://crrev.com/fb5a643e11b7f43639be9b08744486b950c44faf Cr-Commit-Position: refs/heads/master@{#302530}

Patch Set 1 #

Total comments: 10

Patch Set 2 : Review comments #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -13 lines) Patch
M chrome/browser/resources/component_extension_resources.grd View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/hotword/base_session_manager.js View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/hotword/constants.js View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/hotword/manager.js View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/hotword/manifest.json View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/hotword/state_manager.js View 1 2 2 chunks +11 lines, -1 line 0 comments Download
A + chrome/browser/resources/hotword/training_manager.js View 1 2 chunks +16 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Anand Mistry (off Chromium)
https://codereview.chromium.org/687323003/diff/1/chrome/browser/resources/component_extension_resources.grd File chrome/browser/resources/component_extension_resources.grd (right): https://codereview.chromium.org/687323003/diff/1/chrome/browser/resources/component_extension_resources.grd#newcode86 chrome/browser/resources/component_extension_resources.grd:86: <include name="IDR_HOTWORD_TRAINING_MANAGER_JS" file="hotword/training_manager.js" type="BINDATA" /> Keep these in alphabetical ...
6 years, 1 month ago (2014-10-30 03:53:13 UTC) #2
kcarattini
https://codereview.chromium.org/687323003/diff/1/chrome/browser/resources/component_extension_resources.grd File chrome/browser/resources/component_extension_resources.grd (right): https://codereview.chromium.org/687323003/diff/1/chrome/browser/resources/component_extension_resources.grd#newcode86 chrome/browser/resources/component_extension_resources.grd:86: <include name="IDR_HOTWORD_TRAINING_MANAGER_JS" file="hotword/training_manager.js" type="BINDATA" /> On 2014/10/30 03:53:12, Anand ...
6 years, 1 month ago (2014-10-30 05:27:06 UTC) #3
Anand Mistry (off Chromium)
lgtm
6 years, 1 month ago (2014-10-30 05:33:47 UTC) #4
Dan Beam
lgtm
6 years, 1 month ago (2014-10-30 22:19:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/687323003/40001
6 years, 1 month ago (2014-11-03 23:51:48 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years, 1 month ago (2014-11-04 00:45:28 UTC) #8
commit-bot: I haz the power
6 years, 1 month ago (2014-11-04 00:46:00 UTC) #9
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/fb5a643e11b7f43639be9b08744486b950c44faf
Cr-Commit-Position: refs/heads/master@{#302530}

Powered by Google App Engine
This is Rietveld 408576698