Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 6873112: [Chrome OS] Re-enable fetching the owner's name via SignedSettings (Closed)

Created:
9 years, 8 months ago by Chris Masone
Modified:
9 years, 7 months ago
CC:
chromium-reviews, nkostylev+cc_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

[Chrome OS] Re-enable fetching the owner's name via SignedSettings BUG=chromium-os:14326 TEST=unit tests R=mnissler@chromium.org,nkostylev@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=82332

Patch Set 1 #

Total comments: 2

Patch Set 2 : + unit test #

Total comments: 2

Patch Set 3 : address mattias suggestion #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M chrome/browser/chromeos/login/signed_settings.cc View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/signed_settings_unittest.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Denis Lagno
http://codereview.chromium.org/6873112/diff/1/chrome/browser/chromeos/login/signed_settings.cc File chrome/browser/chromeos/login/signed_settings.cc (right): http://codereview.chromium.org/6873112/diff/1/chrome/browser/chromeos/login/signed_settings.cc#newcode709 chrome/browser/chromeos/login/signed_settings.cc:709: return service_->cached_policy().username() terminating semicolon missing
9 years, 8 months ago (2011-04-20 16:24:13 UTC) #1
Chris Masone
Fixed, and now with unit test http://codereview.chromium.org/6873112/diff/1/chrome/browser/chromeos/login/signed_settings.cc File chrome/browser/chromeos/login/signed_settings.cc (right): http://codereview.chromium.org/6873112/diff/1/chrome/browser/chromeos/login/signed_settings.cc#newcode709 chrome/browser/chromeos/login/signed_settings.cc:709: return service_->cached_policy().username() On ...
9 years, 8 months ago (2011-04-20 16:41:51 UTC) #2
Mattias Nissler (ping if slow)
LGTM with a suggestion. http://codereview.chromium.org/6873112/diff/2002/chrome/browser/chromeos/login/signed_settings.cc File chrome/browser/chromeos/login/signed_settings.cc (right): http://codereview.chromium.org/6873112/diff/2002/chrome/browser/chromeos/login/signed_settings.cc#newcode709 chrome/browser/chromeos/login/signed_settings.cc:709: return data.username(); In the other ...
9 years, 8 months ago (2011-04-20 16:48:16 UTC) #3
Chris Masone
will push with commit queue http://codereview.chromium.org/6873112/diff/2002/chrome/browser/chromeos/login/signed_settings.cc File chrome/browser/chromeos/login/signed_settings.cc (right): http://codereview.chromium.org/6873112/diff/2002/chrome/browser/chromeos/login/signed_settings.cc#newcode709 chrome/browser/chromeos/login/signed_settings.cc:709: return data.username(); On 2011/04/20 ...
9 years, 8 months ago (2011-04-20 16:51:27 UTC) #4
commit-bot: I haz the power
9 years, 8 months ago (2011-04-20 17:46:21 UTC) #5

Powered by Google App Engine
This is Rietveld 408576698