Issue 687293002: Issue acquire barrier in SkRefCnt::unique().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 687293002: Issue acquire barrier in SkRefCnt::unique(). (Closed)

Created:
6 years, 1 month ago by bungeman-skia

Modified:
6 years, 1 month ago

Reviewers:
bungeman-chromium, mtklein, reed1

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

Issue acquire barrier in SkRefCnt::unique(). When unique() returns true, it must also issue an acquire barrier. Note that this change may adversly impact SkPath performance, but editing SkPaths is already a performance issue. BUG=chromium:258499 No API changes. TBR=reed@google.com Committed: https://skia.googlesource.com/skia/+/a5cf665997d73169e2f5260eaf9643af1f309762

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	include/core/SkRefCnt.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 6 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/687293002/1

6 years, 1 month ago (2014-10-29 18:38:36 UTC) #5

commit-bot: I haz the power

6 years, 1 month ago (2014-10-29 19:31:39 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as a5cf665997d73169e2f5260eaf9643af1f309762