Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(601)

Issue 687283002: Support multiple scales for dfpaths. (Closed)

Created:
6 years, 1 month ago by jvanverth1
Modified:
6 years, 1 month ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Support multiple scales for dfpaths. Adds miplevel as part of dfpath key, and scale factor so we know how much to adjust to fit desired scale. BUG=skia:2935 Committed: https://skia.googlesource.com/skia/+/b61283f9c7cbec4236d6ce6ce9d0376d3dd81207

Patch Set 1 #

Patch Set 2 : Update ignored GMs #

Total comments: 6

Patch Set 3 : Update based on comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -26 lines) Patch
M expectations/gm/ignored-tests.txt View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
M src/gpu/GrAADistanceFieldPathRenderer.h View 1 2 2 chunks +17 lines, -7 lines 0 comments Download
M src/gpu/GrAADistanceFieldPathRenderer.cpp View 1 2 10 chunks +47 lines, -19 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jvanverth1
6 years, 1 month ago (2014-10-29 18:32:04 UTC) #2
robertphillips
lgtm + some dox suggestions https://codereview.chromium.org/687283002/diff/20001/src/gpu/GrAADistanceFieldPathRenderer.cpp File src/gpu/GrAADistanceFieldPathRenderer.cpp (right): https://codereview.chromium.org/687283002/diff/20001/src/gpu/GrAADistanceFieldPathRenderer.cpp#newcode24 src/gpu/GrAADistanceFieldPathRenderer.cpp:24: #define PLOT_WIDTH 256 Double ...
6 years, 1 month ago (2014-10-29 19:55:03 UTC) #3
jvanverth1
https://codereview.chromium.org/687283002/diff/20001/src/gpu/GrAADistanceFieldPathRenderer.cpp File src/gpu/GrAADistanceFieldPathRenderer.cpp (right): https://codereview.chromium.org/687283002/diff/20001/src/gpu/GrAADistanceFieldPathRenderer.cpp#newcode24 src/gpu/GrAADistanceFieldPathRenderer.cpp:24: #define PLOT_WIDTH 256 On 2014/10/29 19:55:02, robertphillips wrote: > ...
6 years, 1 month ago (2014-10-30 12:48:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/687283002/40001
6 years, 1 month ago (2014-10-30 12:49:05 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-10-30 12:57:25 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as b61283f9c7cbec4236d6ce6ce9d0376d3dd81207

Powered by Google App Engine
This is Rietveld 408576698