Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issue 687273005: X87: Classes: Add super support in methods and accessors (Closed)

Created:
6 years, 1 month ago by chunyang.dai
Modified:
6 years, 1 month ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/external/v8.git@bleeding_edge
Project:
v8
Visibility:
Public.

Description

X87: Classes: Add super support in methods and accessors port r24976. original commit message: Classes: Add super support in methods and accessors This is done by installing the [[HomeObject]] on the method and the accessor functions. BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -11 lines) Patch
M src/x87/full-codegen-x87.cc View 1 chunk +4 lines, -11 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
chunyang.dai
WL. PTAL.
6 years, 1 month ago (2014-10-30 01:52:16 UTC) #2
Weiliang
lgtm
6 years, 1 month ago (2014-10-30 02:00:36 UTC) #3
Weiliang
Committed as r24999
6 years, 1 month ago (2014-10-30 02:02:54 UTC) #4
arv (Not doing code reviews)
6 years, 1 month ago (2014-10-30 08:37:43 UTC) #5
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698