Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(852)

Issue 687263007: Turn SkTaskGroups back on. (Closed)

Created:
6 years, 1 month ago by mtklein_C
Modified:
6 years, 1 month ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Turn SkTaskGroups back on. Revert "Disable SkTaskGroup in SkMultiPictureDraw temporarily." Revert "Revert harder, removing SkTaskGroup.cpp from core temporarily." NOTREECHECKS=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/2100c5ed7a5e5470a04e7af7309d8bd3fc4249f7 Committed: https://skia.googlesource.com/skia/+/ecf987559b1db0cb3fcaccdde2a065e4391d9b60

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -13 lines) Patch
M gyp/SampleApp.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M gyp/core.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M gyp/dm.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M gyp/pathops_skpclip.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M gyp/pathops_unittest.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M gyp/tools.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M src/core/SkMultiPictureDraw.cpp View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/687263007/1
6 years, 1 month ago (2014-10-30 17:06:46 UTC) #2
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 1 month ago (2014-10-30 17:06:47 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Please ask for an LGTM from a full ...
6 years, 1 month ago (2014-10-30 23:06:58 UTC) #5
reed1
lgtm
6 years, 1 month ago (2014-10-31 12:17:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/687263007/1
6 years, 1 month ago (2014-10-31 13:33:41 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/687263007/1
6 years, 1 month ago (2014-10-31 13:38:15 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1) as 2100c5ed7a5e5470a04e7af7309d8bd3fc4249f7
6 years, 1 month ago (2014-10-31 13:38:30 UTC) #13
mtklein
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/693993002/ by mtklein@google.com. ...
6 years, 1 month ago (2014-10-31 18:29:45 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/687263007/1
6 years, 1 month ago (2014-11-04 01:40:59 UTC) #16
commit-bot: I haz the power
6 years, 1 month ago (2014-11-04 01:41:18 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as ecf987559b1db0cb3fcaccdde2a065e4391d9b60

Powered by Google App Engine
This is Rietveld 408576698