Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 687263005: Use module.exports rather than this.exports (Closed)

Created:
6 years, 1 month ago by abarth-chromium
Modified:
6 years, 1 month ago
Reviewers:
esprehn
CC:
esprehn, mojo-reviews_chromium.org, ojan
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -13 lines) Patch
M sky/framework/inspector/console-agent.sky View 1 chunk +1 line, -1 line 0 comments Download
M sky/framework/inspector/dom-agent.sky View 1 chunk +1 line, -1 line 0 comments Download
M sky/framework/inspector/indexeddb-agent.sky View 1 chunk +1 line, -1 line 0 comments Download
M sky/framework/inspector/page-agent.sky View 1 chunk +1 line, -1 line 0 comments Download
M sky/framework/inspector/runtime-agent.sky View 1 chunk +1 line, -1 line 0 comments Download
M sky/framework/inspector/worker-agent.sky View 1 chunk +1 line, -1 line 0 comments Download
M sky/framework/shell.sky View 1 chunk +1 line, -1 line 0 comments Download
M sky/framework/xmlhttprequest.sky View 1 chunk +1 line, -1 line 0 comments Download
M sky/tests/custom-elements/resources/document-register-fuzz.sky View 1 chunk +1 line, -1 line 0 comments Download
M sky/tests/modules/resources/intermediate.sky View 1 chunk +1 line, -1 line 0 comments Download
M sky/tests/modules/resources/pass.sky View 1 chunk +1 line, -1 line 0 comments Download
M sky/viewer/script/core.html View 1 chunk +1 line, -1 line 0 comments Download
M sky/viewer/script/support.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
abarth-chromium
6 years, 1 month ago (2014-10-29 22:20:34 UTC) #1
esprehn
lgtm
6 years, 1 month ago (2014-10-29 22:20:52 UTC) #2
abarth-chromium
6 years, 1 month ago (2014-10-29 22:21:32 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
300b9081cae7d68ba79a7030222f697fd398121b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698